Bug 1172394 - [RFE] rename gwt-extension.jar->ovirt-engine-gwt-extension.jar
Summary: [RFE] rename gwt-extension.jar->ovirt-engine-gwt-extension.jar
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Vojtech Szocs
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On: 1013752
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-10 01:14 UTC by Einav Cohen
Modified: 2022-07-13 12:03 UTC (History)
13 users (show)

Fixed In Version:
Clone Of: 1013752
Environment:
Last Closed: 2016-03-11 17:12:31 UTC
oVirt Team: UX
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-47569 0 None None None 2022-07-13 07:03:43 UTC
oVirt gerrit 26045 0 None None None Never

Description Einav Cohen 2014-12-10 01:14:53 UTC
+++ This bug was initially created as a clone of Bug #1013752 +++

jar name without signature of ovirt can be mistakenly considered 3rd party.

if we can rename it it would be super!

Comment 1 Red Hat Bugzilla Rules Engine 2015-10-19 10:57:29 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 3 Yaniv Kaul 2016-03-10 15:07:36 UTC
Is it going to make it to 4.0?

Comment 4 Vojtech Szocs 2016-03-11 14:58:45 UTC
(In reply to Yaniv Kaul from comment #3)
> Is it going to make it to 4.0?

This BZ was cloned from BZ#1013752 and that one is now closed - I suggest to close this one too.

The issue is that someone might mistake "gwt-extension.jar" as 3rd party (GWT) dependency, but it's our code [a]. On the other hand, "gwt-servlet.jar" is indeed 3rd party (GWT) code, which sits right next to previously mentioned JAR file at [b].

[a] {ovirt_src}/frontend/webadmin/modules/gwt-extension
[b] /usr/share/ovirt-engine/engine.ear/{webadmin,userportal}.war/WEB-INF/lib

As suggested by Tomas in patch https://gerrit.ovirt.org/#/c/48551/ (now abandoned) a proper solution would be to have a consistent naming convention applied across all oVirt JAR files, so for now I'd suggest to close this and discuss/re-open if really needed.

Comment 5 Yaniv Kaul 2016-03-11 17:12:31 UTC
(In reply to vszocs from comment #4)
> (In reply to Yaniv Kaul from comment #3)
> > Is it going to make it to 4.0?
> 
> This BZ was cloned from BZ#1013752 and that one is now closed - I suggest to
> close this one too.

Agreed, thanks.


Note You need to log in before you can comment on or make changes to this bug.