Bug 1173012

Summary: broken ppp-2.4.5-eaptls-mppe-0.99.patch
Product: Red Hat Enterprise Linux 7 Reporter: Michal Sekletar <msekleta>
Component: pppAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED WONTFIX QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: dcb314, extras-qa, jsynacek, msekleta, thozza
Target Milestone: rcKeywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1023620 Environment:
Last Closed: 2019-12-06 16:09:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1023620    
Bug Blocks:    

Description Michal Sekletar 2014-12-11 09:56:40 UTC 
+++ This bug was initially created as a clone of Bug #1023620 +++

I just compiled ppp-2.4.5 with extra gcc compiler flag -Wlogical-op

It said

> eap.c:236:2: warning: logical 'or' of collectively exhaustive tests is always 
true [-Wlogical-op]
> eap.c:1154:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:1189:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2413:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]
> eap.c:2457:2: warning: logical 'or' of collectively exhaustive tests is always
 true [-Wlogical-op]

It looks like the compiler is complaining about the eap_client_active macro.
It is defined in patch file ppp-2.4.5-eaptls-mppe-0.99.patch as follows

+#define    eap_client_active(esp)  ((esp)->es_client.ea_state != eapInitial ||\
+                (esp)->es_client.ea_state != eapPending ||\
+                (esp)->es_client.ea_state != eapClosed)

Suggest swap || for &&
Comment 5 David Binderman 2018-03-20 14:21:55 UTC 
I just checked ppp-2.4.7 and this problem doesn't seem to exist anymore.

Presumably in the over three years since this bug report, someone
has fixed it.
Comment 6 Tomáš Hozza 2019-12-06 16:09:27 UTC 
Red Hat Enterprise Linux version 7 entered the Maintenance Support 1 Phase in August 2019. In this phase only qualified Critical and Important Security errata advisories (RHSAs) and Urgent Priority Bug Fix errata advisories (RHBAs) may be released as they become available. Other errata advisories may be delivered as appropriate.

This bug has been reviewed by Support and Engineering representative and does not meet the inclusion criteria for Maintenance Support 1 Phase. If this issue still exists in newer major version of Red Hat Enterprise Linux, it has been cloned there and work will continue in the cloned bug.

For more information about Red Hat Enterprise Linux Lifecycle, please see https://access.redhat.com/support/policy/updates/errata/
Comment 7 RHEL Program Management 2019-12-06 16:09:33 UTC 
Development Management has reviewed and declined this request. You may appeal this decision by using your Red Hat support channels, who will make certain  the issue receives the proper prioritization with product and development management.

https://www.redhat.com/support/process/production/#howto