Bug 1174030
| Summary: | Review Request: golang-github-appc-spec - Schema defs and tools for app container specification | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Jan Chaloupka <jchaloup> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | jchaloup:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-02 03:15:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1174021 | ||
| Bug Blocks: | 1169966 | ||
|
Description
Lokesh Mandvekar
2014-12-14 23:13:52 UTC
VALID
- BuildRequires are correct
- license is correct
1) Provides: golang(%{import_path}) = %{version}-%{release}
The source codes itself does not contain any *.go files in its root directory. So we should not provide such import paths. However, it is root directory, source codes'prefix. This could be an exception as a way how to shorten all BuildRequires so we don't have to BuildRequire more import paths of the same package. On the other hand, the import paths can be distributed among more subpackages. BuildRequire could become invalid. So I recommend to remove this Provide.
2) CONTRIBUTING.md and SPEC.md should be in %files too as they give more information about the source codes
Otherwise it look ok so far
%changelog * Mon Dec 15 2014 Lokesh Mandvekar <lsm5> - 0.1.1-2 - update metaprovides - update docs packaged Spec URL: https://lsm5.fedorapeople.org/golang-github-appc-spec/golang-github-appc-spec.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-appc-spec/SRPMS/golang-github-appc-spec-0.1.1-2.fc22.src.rpm Change summary from: Summary: Schema defs and tools for app container spec into Summary: Schema defs and tools for app container specification The file conforms to the current Go packaging draft. Approved New Package SCM Request ======================= Package Name: golang-github-appc-spec Short Description: Schema defs and tools for app container specification Upstream URL: https://github.com/appc/spec Owners: jchaloup lsm5 Branches: f21 f20 el6 epel7 InitialCC: golang-sig Git done (by process-git-requests). |