Bug 1174021 - Review Request: golang-github-coreos-go-semver - Go semantic versioning library
Summary: Review Request: golang-github-coreos-go-semver - Go semantic versioning library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1174030
TreeView+ depends on / blocked
 
Reported: 2014-12-14 20:46 UTC by Lokesh Mandvekar
Modified: 2015-04-11 06:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-11 06:02:38 UTC
Type: ---
Embargoed:
jchaloup: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
Update for loop in %check (711 bytes, patch)
2014-12-15 09:38 UTC, Jan Chaloupka
no flags Details | Diff

Comment 1 Jan Chaloupka 2014-12-15 09:38:42 UTC
Created attachment 968849 [details]
Update for loop in %check

The loop should be removed (there is  only one dir so far) or $dir should be used to set go test's subfolder name

Comment 2 Jan Chaloupka 2014-12-15 09:43:39 UTC
There is also example.go file, which could be provided for a developer. But this file is very optional.

Otherwise, the file conforms to the current Go packaging draft.
- licence is correct
- devel subpackage is available and provides all imports

Approved.

Comment 3 Lokesh Mandvekar 2014-12-15 20:57:13 UTC
New Package SCM Request
=======================
Package Name: golang-github-coreos-go-semver
Short Description: Go semantic versioning library
Upstream URL: https://github.com/coreos/go-semver
Owners: lsm5 jchaloup
Branches: f20 f21 el6
InitialCC: golang-sig

Comment 4 Gwyn Ciesla 2014-12-16 13:18:12 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-12-17 07:26:06 UTC
golang-github-coreos-go-semver-0-0.1.git6fe83cc.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-semver-0-0.1.git6fe83cc.fc21

Comment 6 Fedora Update System 2014-12-18 06:05:59 UTC
golang-github-coreos-go-semver-0-0.1.git6fe83cc.fc21 has been pushed to the Fedora 21 testing repository.

Comment 7 Fedora Update System 2015-04-02 18:05:47 UTC
golang-github-coreos-go-semver-0-0.3.git568e959.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-semver-0-0.3.git568e959.fc21


Note You need to log in before you can comment on or make changes to this bug.