Bug 1174030 - Review Request: golang-github-appc-spec - Schema defs and tools for app container specification
Summary: Review Request: golang-github-appc-spec - Schema defs and tools for app conta...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1174021
Blocks: 1169966
TreeView+ depends on / blocked
 
Reported: 2014-12-14 23:13 UTC by Lokesh Mandvekar
Modified: 2015-02-02 03:15 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-02 03:15:30 UTC
Type: Bug
Embargoed:
jchaloup: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Lokesh Mandvekar 2014-12-14 23:13:52 UTC
Spec URL: https://lsm5.fedorapeople.org/golang-github-appc-spec/golang-github-appc-spec.spec
SRPM URL: https://lsm5.fedorapeople.org/golang-github-appc-spec/SRPMS/golang-github-appc-spec-0.1.1-1.fc22.src.rpm

Description: Schema defs and tools for app container spec


Fedora Account System Username: lsm5

Comment 1 Jan Chaloupka 2014-12-15 11:48:53 UTC
VALID
- BuildRequires are correct
- license is correct


1) Provides:   golang(%{import_path}) = %{version}-%{release}
The source codes itself does not contain any *.go files in its root directory. So we should not provide such import paths. However, it is root directory, source codes'prefix. This could be an exception as a way how to shorten all BuildRequires so we don't have to BuildRequire more import paths of the same package. On the other hand, the import paths can be distributed among more subpackages. BuildRequire could become invalid. So I recommend to remove this Provide.

2) CONTRIBUTING.md and SPEC.md should be in %files too as they give more information about the source codes

Otherwise it look ok so far

Comment 2 Lokesh Mandvekar 2014-12-16 04:32:06 UTC
%changelog
* Mon Dec 15 2014 Lokesh Mandvekar <lsm5> - 0.1.1-2
- update metaprovides
- update docs packaged

Spec URL: https://lsm5.fedorapeople.org/golang-github-appc-spec/golang-github-appc-spec.spec
SRPM URL: https://lsm5.fedorapeople.org/golang-github-appc-spec/SRPMS/golang-github-appc-spec-0.1.1-2.fc22.src.rpm

Comment 3 Jan Chaloupka 2014-12-16 11:19:24 UTC
Change summary from:
Summary:    Schema defs and tools for app container spec
into
Summary:    Schema defs and tools for app container specification


The file conforms to the current Go packaging draft.

Approved

Comment 4 Lokesh Mandvekar 2015-02-01 01:28:14 UTC
New Package SCM Request
=======================
Package Name: golang-github-appc-spec
Short Description: Schema defs and tools for app container specification
Upstream URL: https://github.com/appc/spec
Owners: jchaloup lsm5
Branches: f21 f20 el6 epel7
InitialCC: golang-sig

Comment 5 Gwyn Ciesla 2015-02-01 15:43:02 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.