Bug 1176882
| Summary: | Review Request: nodejs-tar-stream - A streaming tar parser and generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-tar-stream-1.1.1-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-31 18:17:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1176809, 1176881 | ||
| Bug Blocks: | 1177550 | ||
|
Description
Piotr Popieluch
2014-12-23 14:42:27 UTC
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-tar-stream.noarch: W: only-non-binary-in-usr-lib nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/xtend /usr/lib/node_modules/xtend nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/readable-stream /usr/lib/node_modules/readable-stream nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/end-of-stream /usr/lib/node_modules/end-of-stream nodejs-tar-stream.noarch: W: dangling-symlink /usr/lib/node_modules/tar-stream/node_modules/bl /usr/lib/node_modules/bl nodejs-tar-stream.src: W: strange-permission nodejs-tar-stream-dl-tests.sh 0755L nodejs-tar-stream.src: W: invalid-url Source1: nodejs-tar-stream-tests-v1.1.1.tar.bz2 2 packages and 0 specfiles checked; 0 errors, 7 warnings. + Source verified with upstream as (sha256sum) srpm tarball: d048774bddd96320151f7924bb51451aed6fe0b583b7e1ec050f56cd14945fb4 upstream tarball: d048774bddd96320151f7924bb51451aed6fe0b583b7e1ec050f56cd14945fb4 + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Fix the Source1 file name APPROVED. New Package SCM Request ======================= Package Name: nodejs-tar-stream Short Description: A streaming tar parser and generator Upstream URL: https://github.com/mafintosh/tar-stream Owners: piotrp Branches: f20 f21 el6 epel7 Git done (by process-git-requests). nodejs-tar-stream-1.1.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-tar-stream-1.1.1-1.fc21 package built in f21. f20 epel7 builds fail, too old version of nodejs-deep-equal. closing report nodejs-tar-stream-1.1.1-1.fc21 has been pushed to the Fedora 21 stable repository. |