Bug 1178646

Summary: [ImportDomain] Engine should add a CDA validation when trying to attach an imported Storage Domain to an un-initalized Data Center
Product: Red Hat Enterprise Virtualization Manager Reporter: rhev-integ
Component: ovirt-engineAssignee: Maor <mlipchuk>
Status: CLOSED ERRATA QA Contact: lkuchlan <lkuchlan>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: acanan, amureini, ecohen, gklein, juwu, lpeer, lsurette, mlipchuk, pzhukov, rbalakri, Rhev-m-bugs, scohen, yeylon, ylavi
Target Milestone: ---Keywords: ZStream
Target Release: 3.5.1Flags: ylavi: Triaged+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Previously, when trying to attach an imported storage domain that carried existing metadata to an uninitialized data center, an exception from VDSM was returned with no proper warning message. With this update, the storage domain is checked for existing metadata and an error message is provided to advise users to attach a clean storage domain first.
Story Points: ---
Clone Of: 1138126 Environment:
Last Closed: 2015-04-28 18:43:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1138126    
Bug Blocks: 1193058, 1197441    

Comment 2 lkuchlan 2015-03-03 12:14:03 UTC
Test using rhevm-3.5.1-0.1.el6ev, vdsm-4.16.12-2.el7ev.x86_64

Comment 3 Allon Mureinik 2015-03-08 11:07:45 UTC
Maor, please provide doctext for this bug (and the 3.6.0 too, while you're at it).

Comment 4 Julie 2015-03-30 06:40:41 UTC
Hi Allon, I'm having trouble understanding this bug but Maor is on PTO. Please let me know if the doc text is not correct.

Kind regards,
Julie

Comment 5 Allon Mureinik 2015-03-30 08:49:03 UTC
(In reply to Julie from comment #4)
> Hi Allon, I'm having trouble understanding this bug but Maor is on PTO.
> Please let me know if the doc text is not correct.
> 
> Kind regards,
> Julie

The doctext seems correct, although I wonder if the phrasing could be improved.
The underlying issue is that VDSM cannot attach an old storage domain with metadata leftovers (i.e., a storage domain that was not cleanly put to maintenance and disconnected from its old setup) to an uninitialized datacenter.

In 3.5.0 (before this fix), we would attempt to attach it, and fail with an ugly exception from VDSM.

In 3.5.1 (after this fix), we check the domain before attempting to attach it, and if it has metadata leftovers, a human-readable CanDoAction message that explains the situation and how to rectify is is displayed.

Comment 6 Julie 2015-03-31 05:55:42 UTC
(In reply to Allon Mureinik from comment #5)
> (In reply to Julie from comment #4)
> > Hi Allon, I'm having trouble understanding this bug but Maor is on PTO.
> > Please let me know if the doc text is not correct.
> > 
> > Kind regards,
> > Julie
> 
> The doctext seems correct, although I wonder if the phrasing could be
> improved.
> The underlying issue is that VDSM cannot attach an old storage domain with
> metadata leftovers (i.e., a storage domain that was not cleanly put to
> maintenance and disconnected from its old setup) to an uninitialized
> datacenter.
> 
> In 3.5.0 (before this fix), we would attempt to attach it, and fail with an
> ugly exception from VDSM.
> 
> In 3.5.1 (after this fix), we check the domain before attempting to attach
> it, and if it has metadata leftovers, a human-readable CanDoAction message
> that explains the situation and how to rectify is is displayed.

Thanks Allon. I have updated the doc text again.

Kind regards,
Julie

Comment 7 Pavel Zhukov 2015-04-18 21:22:49 UTC
*** Bug 1212799 has been marked as a duplicate of this bug. ***

Comment 10 errata-xmlrpc 2015-04-28 18:43:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0888.html