Bug 1178646 – [ImportDomain] Engine should add a CDA validation when trying to attach an imported Storage Domain to an un-initalized Data Center

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1178646 - [ImportDomain] Engine should add a CDA validation when trying to attach an imported Storage Domain to an un-initalized Data Center

Summary:	[ImportDomain] Engine should add a CDA validation when trying to attach an im...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine (Show other bugs)
Sub Component:
Version:	3.5.0
Hardware:	Unspecified Unspecified

Priority	unspecified Severity medium
Target Milestone:	---
Target Release:	3.5.1
Assigned To:	Maor
QA Contact:	lkuchlan
Docs Contact:

URL:
Whiteboard:	storage
Keywords:	ZStream

Duplicates:	1212799 (view as bug list)
Depends On:	1138126
Blocks:	1193058 1197441
	Show dependency tree / graph

Reported:	2015-01-05 03:50 EST by rhev-integ
Modified:	2016-02-10 15:25 EST (History)
CC List:	14 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:	Previously, when trying to attach an imported storage domain that carried existing metadata to an uninitialized data center, an exception from VDSM was returned with no proper warning message. With this update, the storage domain is checked for existing metadata and an error message is provided to advise users to attach a clean storage domain first.
Story Points:	---
Clone Of:	1138126
Environment:
Last Closed:	2015-04-28 14:43:06 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	ylavi: Triaged+

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	34239	master	ABANDONED	core: Add a CDA on attach to an uninitialized Data Center	Never
oVirt gerrit	35226	master	ABANDONED	webadmin: Add a warning when importing a Storage Domain	Never
oVirt gerrit	36454	master	MERGED	core: Add a CDA on attach to an uninitialized Data Center	Never
oVirt gerrit	36546	ovirt-engine-3.5	MERGED	core: Add a CDA on attach to an uninitialized Data Center	Never
Red Hat Product Errata	RHSA-2015:0888	normal	SHIPPED_LIVE	Moderate: Red Hat Enterprise Virtualization Manager 3.5.1 update	2015-04-28 18:40:04 EDT

Groups: None (edit)

Comment 2 lkuchlan 2015-03-03 07:14:03 EST

Test using rhevm-3.5.1-0.1.el6ev, vdsm-4.16.12-2.el7ev.x86_64

Comment 3 Allon Mureinik 2015-03-08 07:07:45 EDT

Maor, please provide doctext for this bug (and the 3.6.0 too, while you're at it).

Comment 4 Julie 2015-03-30 02:40:41 EDT

Hi Allon, I'm having trouble understanding this bug but Maor is on PTO. Please let me know if the doc text is not correct.

Kind regards,
Julie

Comment 5 Allon Mureinik 2015-03-30 04:49:03 EDT

(In reply to Julie from comment #4)
> Hi Allon, I'm having trouble understanding this bug but Maor is on PTO.
> Please let me know if the doc text is not correct.
> 
> Kind regards,
> Julie

The doctext seems correct, although I wonder if the phrasing could be improved.
The underlying issue is that VDSM cannot attach an old storage domain with metadata leftovers (i.e., a storage domain that was not cleanly put to maintenance and disconnected from its old setup) to an uninitialized datacenter.

In 3.5.0 (before this fix), we would attempt to attach it, and fail with an ugly exception from VDSM.

In 3.5.1 (after this fix), we check the domain before attempting to attach it, and if it has metadata leftovers, a human-readable CanDoAction message that explains the situation and how to rectify is is displayed.

Comment 6 Julie 2015-03-31 01:55:42 EDT

(In reply to Allon Mureinik from comment #5)
> (In reply to Julie from comment #4)
> > Hi Allon, I'm having trouble understanding this bug but Maor is on PTO.
> > Please let me know if the doc text is not correct.
> > 
> > Kind regards,
> > Julie
> 
> The doctext seems correct, although I wonder if the phrasing could be
> improved.
> The underlying issue is that VDSM cannot attach an old storage domain with
> metadata leftovers (i.e., a storage domain that was not cleanly put to
> maintenance and disconnected from its old setup) to an uninitialized
> datacenter.
> 
> In 3.5.0 (before this fix), we would attempt to attach it, and fail with an
> ugly exception from VDSM.
> 
> In 3.5.1 (after this fix), we check the domain before attempting to attach
> it, and if it has metadata leftovers, a human-readable CanDoAction message
> that explains the situation and how to rectify is is displayed.

Thanks Allon. I have updated the doc text again.

Kind regards,
Julie

Comment 7 Pavel Zhukov 2015-04-18 17:22:49 EDT

*** Bug 1212799 has been marked as a duplicate of this bug. ***

Comment 10 errata-xmlrpc 2015-04-28 14:43:06 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0888.html

Note You need to log in before you can comment on or make changes to this bug.