Bug 1179835

Summary:	Review Request: fedorazram - zram compresses swap partitions into RAM for performance
Product:	[Fedora] Fedora	Reporter:	Juan Orti <jorti>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, pahan, projects.rg, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-06 20:36:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juan Orti 2015-01-07 16:05:58 UTC

Spec URL: https://jorti.fedorapeople.org/fedorazram/fedorazram.spec
SRPM URL: https://jorti.fedorapeople.org/fedorazram/fedorazram-1.0.0-0.1.20150107git5602a90.fc21.src.rpm
Description: zram compresses swap partitions into RAM for performance
Fedora Account System Username: jorti

Comment 1 Juan Orti 2015-01-07 16:09:25 UTC

*** Bug 1168692 has been marked as a duplicate of this bug. ***

Comment 2 Juan Orti 2015-05-25 07:46:49 UTC

Spec URL: https://jorti.fedorapeople.org/fedorazram/fedorazram.spec
SRPM URL: https://jorti.fedorapeople.org/fedorazram/fedorazram-1.0.0-2.20150525gitd41883a.fc22.src.rpm

Comment 3 Zbigniew Jędrzejewski-Szmek 2015-06-11 16:01:15 UTC

I have significant doubts about the form that this is implemented. That kind of implementation would be fine for SysVInit, but for systemd, running such complicated shell scripts is something we try to avoid. Also using /etc/sysconfig, /bin/sleep, and unloading modules is frowned up. I don't think we should introduce this package into Fedora, and go into a leaner alternative from the start.

I think this could be implemented as a systemd generator in a much cleaner way [1].

[1] http://www.freedesktop.org/software/systemd/man/systemd.generator.html

Comment 4 Juan Orti 2015-06-11 16:21:01 UTC

You are probably right, but it fills a niche that it's currently empty.

I've made a copr with it, I hope it will be useful to someone: https://copr.fedoraproject.org/coprs/jorti/fedorazram/

Comment 5 Pavel Alexeev 2016-09-06 19:45:31 UTC

I post on review it long time ago: https://bugzilla.redhat.com/show_bug.cgi?id=1169926

Comment 6 Juan Orti 2016-09-06 20:36:25 UTC


*** This bug has been marked as a duplicate of bug 1169926 ***

Comment 7 Raphael Groner 2017-07-11 17:56:56 UTC

(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
…
> I think this could be implemented as a systemd generator in a much cleaner
> way [1].
> 
> [1] http://www.freedesktop.org/software/systemd/man/systemd.generator.html

ICYMI Upstream did migrate since over at least two years ago:
https://github.com/mystilleef/FedoraZram/commit/050d0a8267e0df119b7c8e4a10e9ed87600843f1