Bug 1186988
| Summary: | GEOIP_SILENCE support needs to be added to perl-Geo-IP | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Philip Prindeville <philipp> |
| Component: | perl-Geo-IP | Assignee: | Emmanuel Seyman <emmanuel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | emmanuel, paul, perl-devel, philipp |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Geo-IP-1.45-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-04 10:32:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1158667 | ||
| Bug Blocks: | |||
|
Description
Philip Prindeville
2015-01-29 05:19:06 UTC
> the Perl bindings should match this release.
Just so I understand: GeoIP 1.6.4 breaks ABI and I have to rebuild the perl module (which has the version 1.45) against the new package, right?
I don't think it breaks ABI. Philip, if there's an ABI change then 1.6.4 can't be pushed to F-20 and F-21. (In reply to Paul Howarth from comment #2) > I don't think it breaks ABI. > > Philip, if there's an ABI change then 1.6.4 can't be pushed to F-20 and F-21. No, it's ABI compatible. But it introduces some new symbols (like GEOIP_SILENT) which fixes a bug where libGeoIP would write error messages to stderr. I've installed GeoIP 1.6.4 and done some limited testing (basically running the test suite). The current perl module works fine and no rebuild/update seems necessary. I'm closing this bug WORKSFORME. Please re-open if you do notice a problem running the module againt GeoIP-1.6.4. (In reply to Emmanuel Seyman from comment #4) > I've installed GeoIP 1.6.4 and done some limited testing (basically running > the test suite). The current perl module works fine and no rebuild/update > seems necessary. > > I'm closing this bug WORKSFORME. Please re-open if you do notice a problem > running the module againt GeoIP-1.6.4. Reopening: reason is the symbol GEOIP_SILENCE isn't exported in 1.42, but is in 1.45: $ grep GEOIP_SILENCE /usr/lib64/perl5/vendor_perl/Geo/IP.pm $ Please do updates for F20, F21, and F22. perl-Geo-IP is already at 1.45 in F22. I'll release updates for F20 and F21. perl-Geo-IP-1.45-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Geo-IP-1.45-1.fc21 perl-Geo-IP-1.45-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Geo-IP-1.45-1.fc20 Package perl-Geo-IP-1.45-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing perl-Geo-IP-1.45-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-2387/perl-Geo-IP-1.45-1.fc21 then log in and leave karma (feedback). perl-Geo-IP-1.45-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. perl-Geo-IP-1.45-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. See the following bug for an example of a dependency on this fix: https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7079 specifically: https://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URILocalBL.pm?r1=1622551&r2=1622550&pathrev=1622551&diff_format=h |