Bug 1186988 - GEOIP_SILENCE support needs to be added to perl-Geo-IP
Summary: GEOIP_SILENCE support needs to be added to perl-Geo-IP
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-Geo-IP
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1158667
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-29 05:19 UTC by Philip Prindeville
Modified: 2015-03-04 18:42 UTC (History)
4 users (show)

Fixed In Version: perl-Geo-IP-1.45-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-04 10:32:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Philip Prindeville 2015-01-29 05:19:06 UTC
Description of problem:

GeoIP will be updated to 1.6.4 shortly; the Perl bindings should match this release.

Version-Release number of selected component (if applicable):

1.6.4

How reproducible:

N/A

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Emmanuel Seyman 2015-01-29 13:59:17 UTC
> the Perl bindings should match this release.

Just so I understand: GeoIP 1.6.4 breaks ABI and I have to rebuild the perl module (which has the version 1.45) against the new package, right?

Comment 2 Paul Howarth 2015-01-29 15:37:14 UTC
I don't think it breaks ABI.

Philip, if there's an ABI change then 1.6.4 can't be pushed to F-20 and F-21.

Comment 3 Philip Prindeville 2015-01-29 18:55:12 UTC
(In reply to Paul Howarth from comment #2)
> I don't think it breaks ABI.
> 
> Philip, if there's an ABI change then 1.6.4 can't be pushed to F-20 and F-21.

No, it's ABI compatible.  But it introduces some new symbols (like GEOIP_SILENT) which fixes a bug where libGeoIP would write error messages to stderr.

Comment 4 Emmanuel Seyman 2015-02-05 09:36:32 UTC
I've installed GeoIP 1.6.4 and done some limited testing (basically running the test suite). The current perl module works fine and no rebuild/update seems necessary.

I'm closing this bug WORKSFORME. Please re-open if you do notice a problem running the module againt GeoIP-1.6.4.

Comment 5 Philip Prindeville 2015-02-20 01:08:42 UTC
(In reply to Emmanuel Seyman from comment #4)
> I've installed GeoIP 1.6.4 and done some limited testing (basically running
> the test suite). The current perl module works fine and no rebuild/update
> seems necessary.
> 
> I'm closing this bug WORKSFORME. Please re-open if you do notice a problem
> running the module againt GeoIP-1.6.4.

Reopening: reason is the symbol GEOIP_SILENCE isn't exported in 1.42, but is in 1.45:

$ grep GEOIP_SILENCE /usr/lib64/perl5/vendor_perl/Geo/IP.pm 
$ 

Please do updates for F20, F21, and F22.

Comment 6 Emmanuel Seyman 2015-02-20 09:38:33 UTC
perl-Geo-IP is already at 1.45 in F22. I'll release updates for F20 and F21.

Comment 7 Fedora Update System 2015-02-20 10:50:51 UTC
perl-Geo-IP-1.45-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Geo-IP-1.45-1.fc21

Comment 8 Fedora Update System 2015-02-20 10:50:56 UTC
perl-Geo-IP-1.45-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Geo-IP-1.45-1.fc20

Comment 9 Fedora Update System 2015-02-21 04:25:20 UTC
Package perl-Geo-IP-1.45-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Geo-IP-1.45-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2387/perl-Geo-IP-1.45-1.fc21
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2015-03-04 10:32:59 UTC
perl-Geo-IP-1.45-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-03-04 10:35:32 UTC
perl-Geo-IP-1.45-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.