Bug 1201469
Summary: | Review Request: gegl03 - Graph based image processing framework | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kalev Lember <kalevlember> |
Component: | Package Review | Assignee: | Debarshi Ray <debarshir> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | debarshir, kalevlember, package-review |
Target Milestone: | --- | Flags: | debarshir:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | gegl03-0.3.0-0.3.gitc9bbc81.fc22 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-03-13 19:36:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Kalev Lember
2015-03-12 18:24:10 UTC
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9211479 * Fri Mar 13 2015 Kalev Lember <kalevlember> - 0.3.0-0.2.gitc9bbc81 - Update to latest git master, fixing the build on arm Spec URL: https://kalev.fedorapeople.org/gegl03.spec SRPM URL: https://kalev.fedorapeople.org/gegl03-0.3.0-0.2.gitc9bbc81.fc22.src.rpm MUST items ---------- rpmlint output: $ rpmlint gegl03-0.3.0-0.1.git06aea8e.fc22.src.rpm gegl03.src: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing gegl03.src: W: invalid-url Source0: gegl-0.3.0-06aea8e.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint gegl03-0.3.0-0.1.git06aea8e.fc21.x86_64.rpm gegl03.x86_64: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing gegl03.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint gegl03-debuginfo-0.3.0-0.1.git06aea8e.fc21.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint gegl03-devel-0.3.0-0.1.git06aea8e.fc21.x86_64.rpm gegl03-devel.x86_64: W: only-non-binary-in-usr-lib gegl03-devel.x86_64: W: no-documentation gegl03-devel.x86_64: E: zero-length /usr/share/vala/vapi/gegl-0.3.deps 1 packages and 0 specfiles checked; 1 errors, 2 warnings. All those are harmless, except the one about the zero length VAPI file. Maybe we should build with --without-vala ? YES - package follows Naming Guidelines YES - spec file name matches base package %{name} YES - package follows Packaging Guidelines Some minor grammatical errors in %description. "GIMPs itches" should be "GIMP's itches", "minimal dependencies. and a" should be "minimal dependencies and a". There should be a Requires on ImageMagick. operations/common/magick-load.c has a fallback image loader which uses convert(1). We should probably fix these in gegl (the 0.2.x package) also. YES - package is under a Fedora approved license YES - license field matches actual license YES - source package includes license text, which is included in %license YES - spec file written in American English YES - spec file is legible YES - sources match upstream source Since this is a Git snapshot, the checksum of the tarball depends on the exact versions of Autotools. YES - package compiles on all primary architectures YES - there is no need for ExcludeArch YES - all build dependencies in BuildRequires YES - handles locales properly YES - calls ldconfig in %post and %postun YES - doesn't bundle system libraries YES - package is not relocatable YES - package owns all directories that it creates YES - files are listed only once in %files YES - file permissions are set properly YES - consistent use of macros YES - package contains code or permissible content YES - no need for doc subpackage YES - no chance of items marked as %doc affecting runtime YES - no static libraries YES - development files in devel subpackage YES - devel subpackage requires base package YES - package removes all libtool archives YES - package doesn't need a .desktop file YES - doesn't own files or directories owned by other packages YES - all filenames are valid UTF-8 SHOULD items ------------ YES - package includes license text from upstream NO - description and summary doesn't have translations YES - package builds in Koji YES - builds on all primary architectures YES - package functions as described YES - package doesn't use scriptlets YES - no subpackages other than devel YES - pkgconfig files are part of devel subpackage YES - no dependencies outside of /etc/, /bin/, /sbin, etc. YES - no need for man pages (In reply to Debarshi Ray from comment #3) > gegl03-devel.x86_64: E: zero-length /usr/share/vala/vapi/gegl-0.3.deps > 1 packages and 0 specfiles checked; 1 errors, 2 warnings. > > All those are harmless, except the one about the zero length VAPI file. > Maybe we should build with --without-vala ? It's just the .deps file that's zero length, the vapi file seems fine. I think it's harmless, but would be nice to fix it upstream by not including the empty .deps file. > Some minor grammatical errors in %description. "GIMPs itches" should be > "GIMP's itches", "minimal dependencies. and a" should be "minimal > dependencies and a". Fixed both. > There should be a Requires on ImageMagick. > operations/common/magick-load.c has a fallback image loader which uses > convert(1). Done. * Fri Mar 13 2015 Kalev Lember <kalevlember> - 0.3.0-0.3.gitc9bbc81 - Package review fixes (#1201469) - Fix grammar errors in package description - Add a runtime dep on /usr/bin/convert Spec URL: https://kalev.fedorapeople.org/gegl03.spec SRPM URL: https://kalev.fedorapeople.org/gegl03-0.3.0-0.3.gitc9bbc81.fc22.src.rpm (In reply to Kalev Lember from comment #4) > (In reply to Debarshi Ray from comment #3) > > gegl03-devel.x86_64: E: zero-length /usr/share/vala/vapi/gegl-0.3.deps > > 1 packages and 0 specfiles checked; 1 errors, 2 warnings. > > > > All those are harmless, except the one about the zero length VAPI file. > > Maybe we should build with --without-vala ? > > It's just the .deps file that's zero length, the vapi file seems fine. I > think it's harmless, but would be nice to fix it upstream by not including > the empty .deps file. Ok. > > Some minor grammatical errors in %description. "GIMPs itches" should be > > "GIMP's itches", "minimal dependencies. and a" should be "minimal > > dependencies and a". > > Fixed both. > > > > There should be a Requires on ImageMagick. > > operations/common/magick-load.c has a fallback image loader which uses > > convert(1). > > Done. Thanks, Kalev. ACCEPTED New Package SCM Request ======================= Package Name: gegl03 Short Description: Graph based image processing framework Upstream URL: http://www.gegl.org/ Owners: rishi Branches: f22 InitialCC: Git done (by process-git-requests). Package imported and built. |