Bug 1202781
| Summary: | Change in Server name does not reflect in settings accordion | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Aziza Karol <akarol> | ||||||
| Component: | UI - OPS | Assignee: | Milan Zázrivec <mzazrivec> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Aziza Karol <akarol> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.4.0 | CC: | abellott, dclarizi, hkataria, jhardy, jkrocil, kmorey, mpovolny, obarenbo | ||||||
| Target Milestone: | GA | ||||||||
| Target Release: | 5.5.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 5.5.0.1 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-12-08 13:03:40 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1007519 [details]
screenshot with manageiq master branch
Changed appliance name, saved, navigated away and back. Form has correct value, frame title and accordion are wrong. See attached using latest MIQ code.
It looks like the form is displaying the configuration[:server][:name] while the frame title and accordion is using the miq_servers 'name' field. When you save the form, it's only saving the configuration.
irb(main):007:0> MiqServer.my_server.name
=> "EVM"
irb(main):008:0> MiqServer.my_server.configurations.where("typ" => "vmdb").first.settings[:server][:name]
=> "EVM BLAH"
I'm not sure why we have the configuration setting but we should be using the same thing.
To further clarify, the configuration is being edited and saved. The miq_servers row associated with that configuration is not being saved. Unless we're using [:server][:name] from the configuration elsewhere, I'd think we should be editing and saving the miq_servers row and the rest of the configuration with the form's configuration. Thoughts? New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/2c9b55b7bbe8f088d606e3ef91742f6e79abac69 commit 2c9b55b7bbe8f088d606e3ef91742f6e79abac69 Author: Milan Zazrivec <mzazrivec> AuthorDate: Wed May 20 17:31:55 2015 +0200 Commit: Milan Zazrivec <mzazrivec> CommitDate: Wed May 20 17:31:55 2015 +0200 Server name change: modify config file & database data simultaneously https://bugzilla.redhat.com/show_bug.cgi?id=1202781 vmdb/app/controllers/ops_controller/settings/common.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) *** Bug 1228400 has been marked as a duplicate of this bug. *** Verified in 5.5.0.1-alpha1.20150915151429_2230bd4. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:2551 |
Created attachment 1002788 [details] snpshot Description of problem: Version-Release number of selected component (if applicable): 5.4.0.0.12 How reproducible: 100% Steps to Reproduce: 1.Navigate to configure->Configuration 2.click on "Server: EVM [1] (current)" in settings. 3.update the appliance name and save the changes Actual results: new name does not get reflected in the accordion. see attached screenshot. New name is "EVM-CFME" but it still has "EVM". Also the flash message displays the old name when clicked on save Expected results: change in server name should get reflected Additional info: