Bug 1202781 - Change in Server name does not reflect in settings accordion
Summary: Change in Server name does not reflect in settings accordion
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.5.0
Assignee: Milan Zázrivec
QA Contact: Aziza Karol
URL:
Whiteboard:
: 1228400 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-03-17 12:44 UTC by Aziza Karol
Modified: 2015-12-08 13:03 UTC (History)
8 users (show)

Fixed In Version: 5.5.0.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-08 13:03:40 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
snpshot (106.96 KB, image/png)
2015-03-17 12:44 UTC, Aziza Karol
no flags Details
screenshot with manageiq master branch (87.09 KB, image/png)
2015-03-27 21:54 UTC, Joe Rafaniello
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2551 0 normal SHIPPED_LIVE Moderate: CFME 5.5.0 bug fixes and enhancement update 2015-12-08 17:58:09 UTC

Description Aziza Karol 2015-03-17 12:44:56 UTC
Created attachment 1002788 [details]
snpshot

Description of problem:


Version-Release number of selected component (if applicable):
5.4.0.0.12

How reproducible:
100%

Steps to Reproduce:
1.Navigate to configure->Configuration
2.click on "Server: EVM [1] (current)" in settings.
3.update the appliance name and save the changes


Actual results:
new name does not get reflected in the accordion. see attached screenshot.
New name is "EVM-CFME" but it still has "EVM".

Also the flash message displays the old name when clicked on save


Expected results:
change in server name should get reflected

Additional info:

Comment 6 Joe Rafaniello 2015-03-27 21:54:52 UTC
Created attachment 1007519 [details]
screenshot with manageiq master branch

Changed appliance name, saved, navigated away and back.  Form has correct value, frame title and accordion are wrong.   See attached using latest MIQ code.

It looks like the form is displaying the configuration[:server][:name] while the frame title and accordion is using the miq_servers 'name' field.  When you save the form, it's only saving the configuration.


irb(main):007:0> MiqServer.my_server.name
=> "EVM"
irb(main):008:0> MiqServer.my_server.configurations.where("typ" => "vmdb").first.settings[:server][:name]
=> "EVM BLAH"


I'm not sure why we have the configuration setting but we should be using the same thing.

Comment 7 Joe Rafaniello 2015-03-27 22:01:11 UTC
To further clarify, the configuration is being edited and saved.  The miq_servers row associated with that configuration is not being saved.  Unless we're using [:server][:name] from the configuration elsewhere, I'd think we should be editing and saving the miq_servers row and the rest of the configuration with the form's configuration.  Thoughts?

Comment 9 Milan Zázrivec 2015-05-20 15:33:41 UTC
https://github.com/ManageIQ/manageiq/pull/2958

Comment 10 CFME Bot 2015-05-21 17:26:05 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2c9b55b7bbe8f088d606e3ef91742f6e79abac69

commit 2c9b55b7bbe8f088d606e3ef91742f6e79abac69
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed May 20 17:31:55 2015 +0200
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed May 20 17:31:55 2015 +0200

    Server name change: modify config file & database data simultaneously
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1202781

 vmdb/app/controllers/ops_controller/settings/common.rb | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comment 11 Harpreet Kataria 2015-06-04 21:30:54 UTC
*** Bug 1228400 has been marked as a duplicate of this bug. ***

Comment 12 Aziza Karol 2015-09-18 12:16:10 UTC
Verified in 5.5.0.1-alpha1.20150915151429_2230bd4.

Comment 14 errata-xmlrpc 2015-12-08 13:03:40 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551


Note You need to log in before you can comment on or make changes to this bug.