Bug 1202838 (signon-plugin-oauth2)

Summary: Review Request: signon-plugin-oauth2 - OAuth2 plugin for the Accounts framework
Product: [Fedora] Fedora Reporter: Daniel Vrátil <dvratil>
Component: Package ReviewAssignee: Jan Grulich <jgrulich>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jeischma, jgrulich, kevin, package-review
Target Milestone: ---Flags: jgrulich: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-31 09:57:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1070406    
Bug Blocks: 656997, 1202850    

Description Daniel Vrátil 2015-03-17 14:19:30 UTC
Spec URL: https://dvratil.fedorapeople.org/spec/signon-plugin-oauth2.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/signon-plugin-oauth2-0.21-1.fc21.src.rpm
Description: OAuth2 plugin for the Accounts framework. Requires signon-qt5 (review 1070406)
Fedora Account System Username: dvratil

Comment 1 Jan Grulich 2015-03-25 09:09:47 UTC
Fedora-review doesn't seem to work again, so using only rpmlint and licensecheck separately.

rpmlint
--------
signon-plugin-oauth2.src: W: invalid-url Source0: signon-oauth2-0.21.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

licensecheck
------------
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth1plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/base-plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth1plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2tokendata.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth1data.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/common.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2data.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/base-plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/tests/oauth2plugintest.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/tests/oauth2plugintest.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/example/oauthclient.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/example/main.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/example/oauthclient.cpp: LGPL (v2.1)

Looks good in my opinion, APPROVED.

Comment 2 Daniel Vrátil 2015-03-25 09:40:13 UTC
New Package SCM Request
=======================
Package Name: signon-plugin-oauth2
Short Description: OAuth2 plugin for the Accounts framework
Upstream URL: https://code.google.com/p/accounts-sso/
Owners: group::kde-sig
Branches: f22
InitialCC:

Comment 3 Gwyn Ciesla 2015-03-25 11:21:22 UTC
Git done (by process-git-requests).