Bug 1202838 (signon-plugin-oauth2) - Review Request: signon-plugin-oauth2 - OAuth2 plugin for the Accounts framework
Summary: Review Request: signon-plugin-oauth2 - OAuth2 plugin for the Accounts framework
Keywords:
Status: CLOSED RAWHIDE
Alias: signon-plugin-oauth2
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: signon, signon-qt5
Blocks: kde-reviews kaccounts-integration
TreeView+ depends on / blocked
 
Reported: 2015-03-17 14:19 UTC by Daniel Vrátil
Modified: 2015-11-02 01:38 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-03-31 09:57:20 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Daniel Vrátil 2015-03-17 14:19:30 UTC 
Spec URL: https://dvratil.fedorapeople.org/spec/signon-plugin-oauth2.spec
SRPM URL: https://dvratil.fedorapeople.org/spec/signon-plugin-oauth2-0.21-1.fc21.src.rpm
Description: OAuth2 plugin for the Accounts framework. Requires signon-qt5 (review 1070406)
Fedora Account System Username: dvratil
Comment 1 Jan Grulich 2015-03-25 09:09:47 UTC 
Fedora-review doesn't seem to work again, so using only rpmlint and licensecheck separately.

rpmlint
--------
signon-plugin-oauth2.src: W: invalid-url Source0: signon-oauth2-0.21.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

licensecheck
------------
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth1plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/base-plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/plugin.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth1plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2tokendata.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth1data.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/common.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/oauth2data.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/src/base-plugin.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/tests/oauth2plugintest.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/tests/oauth2plugintest.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/example/oauthclient.h: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/example/main.cpp: LGPL (v2.1)
signon-plugin-oauth2-0.21-1.fc21.src/signon-oauth2-0.21/example/oauthclient.cpp: LGPL (v2.1)

Looks good in my opinion, APPROVED.
Comment 2 Daniel Vrátil 2015-03-25 09:40:13 UTC 
New Package SCM Request
=======================
Package Name: signon-plugin-oauth2
Short Description: OAuth2 plugin for the Accounts framework
Upstream URL: https://code.google.com/p/accounts-sso/
Owners: group::kde-sig
Branches: f22
InitialCC:
Comment 3 Gwyn Ciesla 2015-03-25 11:21:22 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.