Bug 1202890 (kaccounts-providers)
| Summary: | Review Request: kaccounts-providers - Additional service providers for KAccounts framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeischma, jgrulich, kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-31 11:05:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1202887 | ||
| Bug Blocks: | 656997, 1135564 | ||
|
Description
Daniel Vrátil
2015-03-17 15:57:20 UTC
rpmlint ------- kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/api.twitter.com.conf kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/identi.ca.conf kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/accounts.google.com.conf kaccounts-providers.noarch: W: non-conffile-in-etc /etc/signon-ui/webkit-options.d/www.facebook.com.conf 1 packages and 0 specfiles checked; 0 errors, 4 warnings. 1) I think you should mark the files installed to /etc as config files with %config Spec URL: https://dvratil.fedorapeople.org/spec/kaccounts-providers.spec SRPM URL: https://dvratil.fedorapeople.org/spec/kaccounts-providers-15.03.90-2.fc21.src.rpm * Wed Mar 25 2015 Daniel Vrátil <dvratil> - 15.03.90-2 - use %%config - use %%license instead of %%doc One minor issue spotted, license should be GPLv2 (at least COPYING says so), but this could be fixed during import. APPROVED. New Package SCM Request ======================= Package Name: kaccounts-providers Short Description: Additional service providers for KAccounts framework Upstream URL: https://projects.kde.org/projects/kde/kdenetwork/kaccounts-providers Owners: group::kde-sig Branches: f22 InitialCC: Git done (by process-git-requests). |