Bug 1208662
| Summary: | SVG icon types set to Fixed (prevents scaling & messes up Gtk apps) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcelo Ricardo Leitner <mleitner> | ||||
| Component: | plasma-breeze | Assignee: | Rex Dieter <rdieter> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 23 | CC: | berrange, ccecchi, crobinso, dap78, fedora, ipilcher, jgrulich, kevin, ltinkl, mclasen, me, mleitner, rdieter, Simon.Gerhards, than, virt-maint | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-01-20 19:50:37 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
virt-manager-1.1.0-6.git8ca8490c.fc22.noarch btw Yeah I don't think that's virt-manager's fault, whatever icon theme you are using likely isn't providing a toolbar sized icon, gtk3 stopped scaling icons in F21 cycle. What desktop environment are you using? Probably reassign the bug to their icon theme for further triage Hi Cole. I'm using KDE, using the default icon theme, breeze. Moving then, but please fix it if I did it wrong. Thanks! Folks, any news on this? It's really annoying to loose a big part of the screen to this. Naively, I'd still assume this to be an application issue... it should scale icons (if needed) virt-manager's UI is using glade, which AFAICT doesn't provide any way to enable scaling with gtk. Since IIRC gtk 3.10 it's been a bit extra work to say 'scale this icon to a non-default size' Since it seems breeze-icon-theme ships only .svg icons compared to gtk's multiple sized .png images, maybe there's some gtk setting breeze can set in the theme to enable scaling by default? otherwise all gtk apps are going to need to deal with things like this... Poking gtk3 devs for advice here, about how gtk3 applications are expected to deal with (mostly) svg-only icon themes. *** Bug 1280122 has been marked as a duplicate of this bug. *** *** Bug 1234376 has been marked as a duplicate of this bug. *** One of those dupes is on f23 as well, so the issue is still present. Anyone on the gnome side have a suggestion here? I've been doing a bit of digging on this (yay strace!), and the problem does seem to be that Plasma themes provide 22x22 icons, but Gtk is looking for 24x24. When it can't find a 24x24 icon, it moves up to the next size that is available -- 32x32 in the case of the shutdown icon, 64x64 in the case of the details icon. Looking at http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html, I see a number of icon scaling/size-related keys that aren't present in /usr/share/icons/breeze/index.theme, e.g.: * Type=Scalable or Type=Threshold * MaxSize * MinSize * Threshold And in fact, setting Type=Scalable, MinSize=23 and MaxSize=256 for the [status/64] directory causes the details icon to be scaled as one would expect. So I'm going to say that this is an issue with the theme, rather than Gtk. Thanks for the excellent detective-work The upstream bug is marked as fixed, can you confirm that? Upstream fixed it by adding 24x24 icons for the toolbar icons. Upstream fix was included in (at least) breeze-icon-theme-5.18.0 and newer (in stable updates now), https://bodhi.fedoraproject.org/updates/FEDORA-2016-68b5eec2f4 |
Created attachment 1010309 [details] toolbar screenshot Please check the attachment. The icon is just too big for this toolbar. This is probably not a virt-manager issue but a template one, but I don't know which component I should report it against.