Bug 1214273

Summary:	Attach/Detach command o/p needs refinement
Product:	[Community] GlusterFS	Reporter:	Anoop <annair>
Component:	tiering	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED DUPLICATE	QA Contact:	bugs <bugs>
Severity:	medium	Docs Contact:
Priority:	high
Version:	mainline	CC:	bugs, dlambrig, josferna, nchilaka, ndevos, rkavunga
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-18 06:41:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1260923

Description Anoop 2015-04-22 10:40:04 UTC

gluster volume detach-tier needs meaningful o/p.

This is the current o/p for gluster vol detach-tier
"Volume detach-tier failed"

This does not tell anything. The o/p here needs to be more informative and tell things like ; detach for which volume, usage etc.

Comment 1 Anoop 2015-04-22 10:45:55 UTC

Another o/p which needs refinement is o/p for sucessful detach.

This is how it looks like today:
[root@dhcp35-56 gfs]# gluster vol detach-tier vol1
volume remove-brick unknown: success

Above o/p does not make sense.

Comment 2 Anoop 2015-04-22 12:46:00 UTC

Another one:

[root@dhcp35-56 ~]# gluster vol attach-tier vol1 replica 2 10.70.35.56:/rhs/brick5 10.70.35.67:/rhs/brick5 force
volume add-brick: success

Why should attach tier give "volume add-brick: success"? It should be more meaningful, something like, "tier attach: success" and also info on which volume it is getting attached to.

Comment 3 Niels de Vos 2015-05-15 13:07:39 UTC

This change should not be in "ON_QA", the patch posted for this bug is only available in the master branch and not in a release yet. Moving back to MODIFIED until there is an beta release for the next GlusterFS version.

Comment 4 Niels de Vos 2015-05-15 15:45:02 UTC

Rafi, you moved this bug ASSIGNED -> POST -> MODIFIED. I can not find a change in Gerrit addresses this bug. Is this bug a duplicate of an other? Or can you post the link to the change so that I can review my search/check/compare workflow?

Comment 5 Mohammed Rafi KC 2015-05-18 04:31:34 UTC

Included the changes as part of another bug, Patch for the change is : http://review.gluster.org/#/c/10713/

Comment 6 Niels de Vos 2015-05-18 06:41:39 UTC

(In reply to Mohammed Rafi KC from comment #5)
> Included the changes as part of another bug, Patch for the change is :
> http://review.gluster.org/#/c/10713/

http://review.gluster.org/10284 is the original patch for the master branch:

    cli/tiering: Enhance cli output for tiering
    
    Fix for handling cli output for attach-tier and
    detach-tier
    
    Change-Id: I4d17f4b09612754fe1b8cec6c2e14927029b9678
    BUG: 1211562
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/10284
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

*** This bug has been marked as a duplicate of bug 1211562 ***