Bug 1214273 - Attach/Detach command o/p needs refinement
Summary: Attach/Detach command o/p needs refinement
Keywords:
Status: CLOSED DUPLICATE of bug 1211562
Alias: None
Product: GlusterFS
Classification: Community
Component: tiering
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: Mohammed Rafi KC
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks: 1260923
TreeView+ depends on / blocked
 
Reported: 2015-04-22 10:40 UTC by Anoop
Modified: 2015-10-30 17:32 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-18 06:41:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anoop 2015-04-22 10:40:04 UTC
gluster volume detach-tier needs meaningful o/p.

This is the current o/p for gluster vol detach-tier
"Volume detach-tier failed"

This does not tell anything. The o/p here needs to be more informative and tell things like ; detach for which volume, usage etc.

Comment 1 Anoop 2015-04-22 10:45:55 UTC
Another o/p which needs refinement is o/p for sucessful detach.

This is how it looks like today:
[root@dhcp35-56 gfs]# gluster vol detach-tier vol1
volume remove-brick unknown: success

Above o/p does not make sense.

Comment 2 Anoop 2015-04-22 12:46:00 UTC
Another one:

[root@dhcp35-56 ~]# gluster vol attach-tier vol1 replica 2 10.70.35.56:/rhs/brick5 10.70.35.67:/rhs/brick5 force
volume add-brick: success

Why should attach tier give "volume add-brick: success"? It should be more meaningful, something like, "tier attach: success" and also info on which volume it is getting attached to.

Comment 3 Niels de Vos 2015-05-15 13:07:39 UTC
This change should not be in "ON_QA", the patch posted for this bug is only available in the master branch and not in a release yet. Moving back to MODIFIED until there is an beta release for the next GlusterFS version.

Comment 4 Niels de Vos 2015-05-15 15:45:02 UTC
Rafi, you moved this bug ASSIGNED -> POST -> MODIFIED. I can not find a change in Gerrit addresses this bug. Is this bug a duplicate of an other? Or can you post the link to the change so that I can review my search/check/compare workflow?

Comment 5 Mohammed Rafi KC 2015-05-18 04:31:34 UTC
Included the changes as part of another bug, Patch for the change is : http://review.gluster.org/#/c/10713/

Comment 6 Niels de Vos 2015-05-18 06:41:39 UTC
(In reply to Mohammed Rafi KC from comment #5)
> Included the changes as part of another bug, Patch for the change is :
> http://review.gluster.org/#/c/10713/

http://review.gluster.org/10284 is the original patch for the master branch:

    cli/tiering: Enhance cli output for tiering
    
    Fix for handling cli output for attach-tier and
    detach-tier
    
    Change-Id: I4d17f4b09612754fe1b8cec6c2e14927029b9678
    BUG: 1211562
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/10284
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur>

*** This bug has been marked as a duplicate of bug 1211562 ***


Note You need to log in before you can comment on or make changes to this bug.