Bug 1218963

Summary:	NFS-Ganesha : Locking of global option file used by NFS-Ganesha.
Product:	[Community] GlusterFS	Reporter:	Meghana <mmadhusu>
Component:	ganesha-nfs	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	bugs, gluster-bugs, kkeithle, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1200254	Environment:
Last Closed:	2015-05-14 17:29:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1200254
Bug Blocks:	1188184, 1199352

Description Meghana 2015-05-06 10:00:59 UTC

+++ This bug was initially created as a clone of Bug #1200254 +++

Description of problem:

The global option gluster features.ganesha enable will
write into the global 'option' file. Currently, only the snapshot
feature writes into this file. But with CLI changes getting merged,
NFS-Ganesha also writes into the same file.
http://review.gluster.org/#/c/9538/

To handle concurrent multiple transactions correctly, a new lock has to
be introduced on this file. Every operation using this file needs to contest
for the new lock type. This bug is opened to track that change.

--- Additional comment from Meghana on 2015-03-12 00:53:44 EDT ---

Review comments that need to addressed :

1. In the function, __glusterd_handle_ganesha_cmd , change the log level
in gf_log to GF_LOG_DEBUG.

2. Remove validation of key/value in either commit/stage phase in
CLI global option patch.

--- Additional comment from Meghana on 2015-03-30 05:46:39 EDT ---

gluster vol info shows inconsistent values for features.ganesha. Check and fix in the same patch

--- Additional comment from Anand Avati on 2015-04-06 02:14:22 EDT ---

REVIEW: http://review.gluster.org/10130 (NFS-Ganesha : Locking global options file) posted (#1) for review on master by Meghana M (mmadhusu)

--- Additional comment from Anand Avati on 2015-04-09 09:13:50 EDT ---

REVIEW: http://review.gluster.org/10130 (NFS-Ganesha : Locking global options file) posted (#2) for review on master by Meghana M (mmadhusu)

--- Additional comment from Anand Avati on 2015-04-21 06:31:43 EDT ---

REVIEW: http://review.gluster.org/10130 (NFS-Ganesha : Locking global options file) posted (#3) for review on master by Meghana M (mmadhusu)

--- Additional comment from Anand Avati on 2015-05-05 08:25:55 EDT ---

REVIEW: http://review.gluster.org/10130 (NFS-Ganesha : Locking global options file) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Anand Avati on 2015-05-06 00:24:33 EDT ---

REVIEW: http://review.gluster.org/10130 (NFS-Ganesha : Locking global options file) posted (#6) for review on master by Meghana M (mmadhusu)

Comment 1 Anand Avati 2015-05-06 10:44:42 UTC

REVIEW: http://review.gluster.org/10606 (NFS-Ganesha : Locking global options file) posted (#1) for review on release-3.7 by Meghana M (mmadhusu)

Comment 2 Anand Avati 2015-05-07 09:08:49 UTC

COMMIT: http://review.gluster.org/10606 committed in release-3.7 by Niels de Vos (ndevos) 
------
commit 4aad69a8f88acf384c812316aaa985cde2229cd7
Author: Meghana Madhusudhan <mmadhusu>
Date:   Mon Apr 20 10:41:47 2015 +0530

    NFS-Ganesha : Locking global options file
    
    Global option gluster features.ganesha enable
    writes into the global 'option' file. The snapshot
    feature also writes into the same file.
    
    To handle concurrent multiple transactions correctly,
    a new lock has to be introduced on this file.
    Every operation using this file needs
    to contest for the new lock type.
    
    This is a back-port of the patch,
    http://review.gluster.org/#/c/10130/
    
    Change-Id: I1fdd285814e615a13dbf8c88ad2b7ee311247f90
    BUG: 1218963
    Signed-off-by: Meghana Madhusudhan <mmadhusu>
    Reviewed-on: http://review.gluster.org/10606
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: NetBSD Build System
    Reviewed-by: Avra Sengupta <asengupt>

Comment 3 Niels de Vos 2015-05-14 17:29:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:36:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:47:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user