Bug 1222915

Summary:	usage text is wrong for use-readdirp mount default
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	fuse	Assignee:	Dustin Black <dblack>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, dblack
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1222148
Clones:	1222917 1384345 (view as bug list)		Environment:
Last Closed:	2017-03-27 18:22:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1222148, 1222917, 1384345

Description Niels de Vos 2015-05-19 12:41:04 UTC

+++ This bug was initially created as a clone of Bug #1222148 +++

glusterfsd/src/glusterfsd.c:215
        {"use-readdirp", ARGP_FUSE_USE_READDIRP_KEY, "BOOL", OPTION_ARG_OPTIONAL,
         "Use readdirp mode in fuse kernel module"
         " [default: \"off\"]"},


glusterfsd/src/glusterfsd.c:1077
        case ARGP_FUSE_USE_READDIRP_KEY:
                if (!arg)
                        arg = "yes";


The default should be yes anyway, so just need to fix the text in line 217

Even better would be to have these kind of options and their help text come from each translator's volume_options struct so changes don't come from multiple places. Perhaps that struct should be in include files?

Comment 1 Vijay Bellur 2016-06-02 21:02:58 UTC

REVIEW: http://review.gluster.org/14622 (Corrected default text for ARGP_FUSE_USE_READDIRP_KEY Changed from "off" to "yes" per BZ 1222915) posted (#1) for review on master by Dustin Black (dblack)

Comment 2 Dustin Black 2016-06-02 21:05:30 UTC

http://review.gluster.org/#/c/14622/

Comment 3 Vijay Bellur 2016-06-06 15:01:45 UTC

COMMIT: http://review.gluster.org/14622 committed in master by Jeff Darcy (jdarcy) 
------
commit 66cc92c25ec2680e50a6b3edda2e027635c380db
Author: Dustin Black <dblack>
Date:   Thu Jun 2 17:01:32 2016 -0400

    Corrected default text for ARGP_FUSE_USE_READDIRP_KEY
    Changed from "off" to "yes" per BZ 1222915
    
    Change-Id: Idffffee621560adb4cc02c1001d1ae21ca11941f
    BUG: 1222915
    Signed-off-by: Dustin Black <dblack>
    Reviewed-on: http://review.gluster.org/14622
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: jiffin tony Thottan <jthottan>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 4 Shyamsundar 2017-03-27 18:22:53 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/