Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1222917

Summary:	usage text is wrong for use-readdirp mount default
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	fuse	Assignee:	ankit <anraj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	anraj, bugs
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.17	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1222915	Environment:
Last Closed:	2016-11-16 10:51:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1222915, 1384345
Bug Blocks:

Description Niels de Vos 2015-05-19 12:42:17 UTC

+++ This bug was initially created as a clone of Bug #1222915 +++

glusterfsd/src/glusterfsd.c:215
        {"use-readdirp", ARGP_FUSE_USE_READDIRP_KEY, "BOOL", OPTION_ARG_OPTIONAL,
         "Use readdirp mode in fuse kernel module"
         " [default: \"off\"]"},


glusterfsd/src/glusterfsd.c:1077
        case ARGP_FUSE_USE_READDIRP_KEY:
                if (!arg)
                        arg = "yes";


The default should be yes anyway, so just need to fix the text in line 217

Even better would be to have these kind of options and their help text come from each translator's volume_options struct so changes don't come from multiple places. Perhaps that struct should be in include files?

Comment 1 Worker Ant 2016-10-06 09:31:54 UTC

REVIEW: http://review.gluster.org/15619 (nfs: usage text rectified for use-readdirp mount default) posted (#1) for review on release-3.7 by ankitraj

Comment 2 Worker Ant 2016-10-08 05:54:00 UTC

REVIEW: http://review.gluster.org/15619 (nfs: usage text rectified for use-readdirp mount default) posted (#2) for review on release-3.7 by ankitraj

Comment 3 Worker Ant 2016-10-17 05:52:10 UTC

COMMIT: http://review.gluster.org/15619 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit a8d8f6b44d04f11219abe4d001a917cdc493ec80
Author: ankitraj <anraj>
Date:   Thu Oct 6 15:00:32 2016 +0530

    nfs: usage text rectified for use-readdirp mount default
    
    Backport of http://review.gluster.org/#/c/14622/
    
    Issue and Solution:
    
    Corrected default text for ARGP_FUSE_USE_READDIRP_KEY Changed
     from "off" to "yes". Struct sholud be included in the file.
    
    Bug: 1222917
    
    Change-Id: Iab418c0d65dd6859402217a10293002d0be3c89e
    Signed-off-by: ankitraj <anraj>
    Reviewed-on: http://review.gluster.org/15619
    Tested-by: ankitraj
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Samikshan Bairagya 2016-11-16 10:51:48 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.17, please open a new bug report.

glusterfs-3.7.17 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/gluster-devel/2016-November/051414.html
[2] https://www.gluster.org/pipermail/gluster-users/