Bug 1225183
| Summary: | ceph sysvinit script calls ceph-disk when it may not be present | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Ceph Storage | Reporter: | Travis Rhoden <trhoden> |
| Component: | Build | Assignee: | Ken Dreyer (Red Hat) <kdreyer> |
| Status: | CLOSED ERRATA | QA Contact: | ceph-qe-bugs <ceph-qe-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.3.0 | CC: | flucifre, hnallurv, hyelloji, kdreyer |
| Target Milestone: | rc | ||
| Target Release: | 1.3.2 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ceph-0.94.5-2.el7cp | Doc Type: | Known Issue |
| Doc Text: |
Ceph init script calls a non-present command
The Ceph init script calls the *ceph-disk* command which is not present on monitor nodes. Consequently, when running the *service ceph start* command with no arguments, an error is returned. This error does not effect functionality of starting and stopping daemons.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-29 14:42:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1262054 | ||
Since this is cosmetic, I'm pushing it to 1.3.2 *** Bug 1274810 has been marked as a duplicate of this bug. *** https://github.com/ceph/ceph/pull/7286 solves this in my testing. call to ceph-disk has been taken care when it it is not present.,
works fine now.
Moving to Verified state..
Result:
--------------
[ubuntu@magna042 ~]$ sudo service ceph status
=== mon.magna042 ===
mon.magna042: running {"version":"0.94.5-4.el7cp"}
[ubuntu@magna042 ~]$ ps -ef | grep ceph
root 31239 1 0 10:55 ? 00:00:00 /bin/bash -c ulimit -n 32768; TCMALLOC_MAX_TOTAL_THREAD_CACHE_BYTES=128MB /usr/bin/ceph-mon -i magna042 --pid-file /var/run/ceph/mon.magna042.pid -c /etc/ceph/ceph.conf --cluster ceph -f
root 31247 31239 0 10:55 ? 00:00:00 /usr/bin/ceph-mon -i magna042 --pid-file /var/run/ceph/mon.magna042.pid -c /etc/ceph/ceph.conf --cluster ceph -f
ubuntu 32070 31758 0 10:57 pts/0 00:00:00 grep --color=auto ceph
[ubuntu@magna042 ~]$ sudo service ceph stop
=== mon.magna042 ===
Stopping Ceph mon.magna042 on magna042...kill 31247...done
[ubuntu@magna042 ~]$ ps -ef | grep ceph
ubuntu 32152 31758 0 10:58 pts/0 00:00:00 grep --color=auto ceph
[ubuntu@magna042 ~]$ sudo service ceph start
=== mon.magna042 ===
Starting Ceph mon.magna042 on magna042...
Running as unit run-32355.service.
Starting ceph-create-keys on magna042...
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:0313 |
Description of problem: With the ceph-mon vs ceph-osd split packaging, it is a common/expected thing for a node to have ceph-mon installed and not ceph-osd (and vice versa). However, the init script (/etc/init.d/ceph) has a call to `ceph-disk`, which may not be present on the machine. This just produces an error at the end, and only happens if running "service ceph start" with no arguments. If running something like "service ceph start mon.`hostname`, the code is not triggered. Version-Release number of selected component (if applicable): [root@srv ~]# rpm -q ceph-mon ceph-mon-0.94.1-11.el7cp.x86_64 How reproducible: Very Steps to Reproduce: 1. Use ice-setup and ceph-deploy to install a 1-node cluster with 1 mon and no OSDs 2. Go to monitor node and issue: "service ceph stop; service ceph start" Actual results: [root@srv ~]# service ceph status === mon.srv === mon.srv: running {"version":"0.94.1"} [root@srv ~]# service ceph stop === mon.srv === Stopping Ceph mon.srv on srv...kill 12961...done [root@srv ~]# [root@srv ~]# [root@srv ~]# [root@srv ~]# [root@srv ~]# ps -ef | grep ceph root 13516 13343 0 14:37 pts/0 00:00:00 grep --color=auto ceph [root@srv ~]# service ceph start === mon.srv === Starting Ceph mon.srv on srv... Running as unit run-13614.service. Starting ceph-create-keys on srv... /etc/init.d/ceph: line 496: ceph-disk: command not found Expected results: No error about a missing script/binary Additional info: Since it's the last thing that happens in the script, this does not effect functionality of starting/stopping daemons. It's just noise. It could be fixed with something like a check to see that the ceph-disk executable exists before calling it.