Bug 1226665
Summary: | gf_store_save_value fails to check for errors, leading to emptying files in /var/lib/glusterd/ | ||||||
---|---|---|---|---|---|---|---|
Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Cedric Buissart <cbuissar> | ||||
Component: | glusterd | Assignee: | Gaurav Kumar Garg <ggarg> | ||||
Status: | CLOSED ERRATA | QA Contact: | Byreddy <bsrirama> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | rhgs-3.0 | CC: | amukherj, asrivast, bhubbard, bsrirama, divya, ggarg, nlevinki, nsathyan, sasundar, smohan, vagarwal, vbellur | ||||
Target Milestone: | --- | Keywords: | Patch, ZStream | ||||
Target Release: | RHGS 3.1.1 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | glusterfs-3.7.1-12 | Doc Type: | Bug Fix | ||||
Doc Text: |
Previously, when there was no space left on the file system and when user performed any operation resulted to change in /var/lib/glusterd/* files, then the glusterd was failing to write to a temporary file. With this fix, a proper error message is displayed when /var/lib/glusterd/* is full.
|
Story Points: | --- | ||||
Clone Of: | |||||||
: | 1226829 (view as bug list) | Environment: | |||||
Last Closed: | 2015-10-05 07:09:38 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1226829, 1251815, 1253148 | ||||||
Attachments: |
|
Description
Cedric Buissart
2015-05-31 15:47:34 UTC
Created attachment 1032891 [details]
check fflush's return value
checking feof() does not seem to be sufficient for catching errors.
Upstream patch http://review.gluster.org/11029 is merged now downstream patch url: https://code.engineering.redhat.com/gerrit/54977 Verified this Bug with version "glusterfs-3.7.1-12" Steps used: ~~~~~~~~~~~ 1. Filled up /var 2. glusterd restart failed. 3. Checked glusterd log for the error message. (no space). Portion of log: ~~~~~~~~~~~~~~~ [2015-08-27 16:53:08.807647] I [MSGID: 106163] [glusterd-handshake.c:1193:__glusterd_mgmt_hndsk_versions_ack] 0-management: using the op-version 30703 [2015-08-27 16:53:08.834497] E [MSGID: 101012] [store.c:72:gf_store_mkstemp] 0-: Failed to open /var/lib/glusterd/glusterd.info.tmp. [No space left on device] [2015-08-27 16:53:08.834560] E [MSGID: 106177] [glusterd-store.c:1898:glusterd_store_global_info] 0-management: Failed to store glusterd global-info [2015-08-27 16:53:08.834584] E [MSGID: 106089] [glusterd-handshake.c:1199:__glusterd_mgmt_hndsk_versions_ack] 0-management: Failed to store op-version [2015-08-27 16:53:11.816557] I [MSGID: 106163] [glusterd-handshake.c:1193:__glusterd_mgmt_hndsk_versions_ack] 0-management: using the op-version 30703 [2015-08-27 16:53:11.841544] E [MSGID: 101012] [store.c:72:gf_store_mkstemp] 0-: Failed to open /var/lib/glusterd/glusterd.info.tmp. [No space left on device] [2015-08-27 16:53:11.841604] E [MSGID: 106177] [glusterd-store.c:1898:glusterd_store_global_info] 0-management: Failed to store glusterd global-info [2015-08-27 16:53:11.841628] E [MSGID: 106089] [glusterd-handshake.c:1199:__glusterd_mgmt_hndsk_versions_ack] 0-management: Failed to store op-version [2015-08-27 16:53:14.826202] I [MSGID: 106163] [glusterd-handshake.c:1193:__glusterd_mgmt_hndsk_versions_ack] 0-management: using the op-version 30703 [2015-08-27 16:53:14.857281] E [MSGID: 101012] [store.c:72:gf_store_mkstemp] 0-: Failed to open /var/lib/glusterd/glusterd.info.tmp. [No space left on device] [2015-08-27 16:53:14.857346] E [MSGID: 106177] [glusterd-store.c:1898:glusterd_store_global_info] 0-management: Failed to store glusterd global-info [2015-08-27 16:53:14.857370] E [MSGID: 106089] [glusterd-handshake.c:1199:__glusterd_mgmt_hndsk_versions_ack] 0-management: Failed to store op-version [2015-08-27 16:53:17.835288] I [MSGID: 106163] [glusterd-handshake.c:1193:__glusterd_mgmt_hndsk_versions_ack] 0-management: using the op-version 30703 [2015-08-27 16:53:17.872672] E [MSGID: 101012] [store.c:72:gf_store_mkstemp] 0-: Failed to open /var/lib/glusterd/glusterd.info.tmp. [No space left on device] [2015-08-27 16:53:17.872738] E [MSGID: 106177] [glusterd-store.c:1898:glusterd_store_global_info] 0-management: Failed to store glusterd global-info Moving this bug to verified state based on above verification result. Gaurav, Please review and sign-off the edited text. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-1845.html |