Bug 1226881

Summary: tiering:compiler warning with gcc v5.1.1
Product: [Community] GlusterFS Reporter: Mohammed Rafi KC <rkavunga>
Component: tieringAssignee: Mohammed Rafi KC <rkavunga>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: urgent Docs Contact:
Priority: urgent    
Version: mainlineCC: bugs
Target Milestone: ---Keywords: Reopened, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1229272 1231767 1271249 (view as bug list) Environment:
Last Closed: 2016-06-16 13:07:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1229272, 1231767, 1260923, 1271249    
Attachments:
Description Flags
warnings none

Description Mohammed Rafi KC 2015-06-01 11:29:53 UTC
Description of problem:

gcc v5.1.1 throws warning for calling a static function from a non-static inline function.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.compile with gcc v5.1.1
2.
3.

Actual results:

couple of compiler warning

Expected results:

should be free from compiler warning

Additional info:

Comment 1 Anand Avati 2015-06-01 11:39:18 UTC
REVIEW: http://review.gluster.org/11032 (tiering:static function called from a non static inline function) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

Comment 2 Mohammed Rafi KC 2015-06-01 11:46:16 UTC
Created attachment 1033276 [details]
warnings

Comment 3 Anand Avati 2015-06-02 05:30:00 UTC
REVIEW: http://review.gluster.org/11032 (tiering:static function called from a non static inline function) posted (#3) for review on master by mohammed rafi  kc (rkavunga)

Comment 4 Anand Avati 2015-06-02 22:00:25 UTC
COMMIT: http://review.gluster.org/11032 committed in master by Niels de Vos (ndevos) 
------
commit 3a94f4c52b56f08c326d3212ca5708e8daf8585b
Author: Mohammed Rafi KC <rkavunga>
Date:   Mon Jun 1 16:53:32 2015 +0530

    tiering:static function called from a non static inline function
    
    gcc v5.1.1 throws warning for calling a static function from a
    non-static inline function.
    
    
    <snippet from compiler warning>
      CC       tier.lo
    tier.c:610:15: warning: 'tier_migrate_using_query_file' is static but used in inline function 'tier_migrate_files_using_qfile' which is not static
             ret = tier_migrate_using_query_file ((void *)query_cbk_args);
                   ^
    tier.c:585:47: warning: 'tier_process_brick_cbk' is static but used in inline function 'tier_build_migration_qfile' which is not static
             ret = dict_foreach (args->brick_list, tier_process_brick_cbk,
                                                   ^
    tier.c:565:176: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:565:158: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:563:58: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:563:40: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
             ret = remove (GET_QFILE_PATH (is_promotion));
                                            ^
      CCLD     tier.la
    
    </snip>
    
    Change-Id: I46046feeb79ab4e2724b0ba6b02c9ec8b121ff4e
    BUG: 1226881
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/11032
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Anoop C S <achiraya>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 5 Vijay Bellur 2015-10-12 12:00:01 UTC
REVIEW: http://review.gluster.org/12342 (tier/shd: inline warning when compiled with gcc v.5) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

Comment 6 Vijay Bellur 2015-10-13 12:46:14 UTC
COMMIT: http://review.gluster.org/12342 committed in master by Dan Lambright (dlambrig) 
------
commit fc8df80f157c148cf60500be14c1f6a9aeed8d7b
Author: Mohammed Rafi KC <rkavunga>
Date:   Mon Oct 12 17:22:20 2015 +0530

    tier/shd: inline warning when compiled with gcc v.5
    
    Change-Id: I487a26263d6e940eed364a831e99f9b8390bc96a
    BUG: 1226881
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/12342
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Anoop C S <anoopcs>
    Tested-by: Anoop C S <anoopcs>
    Tested-by: Dan Lambright <dlambrig>

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 14:50:32 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 13:07:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user