Bug 1229272 - tiering:compiler warning with gcc v5.1.1
Summary: tiering:compiler warning with gcc v5.1.1
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: tier
Version: rhgs-3.1
Hardware: Unspecified
OS: Unspecified
urgent
urgent
Target Milestone: ---
: ---
Assignee: Mohammed Rafi KC
QA Contact: Nag Pavan Chilakam
URL:
Whiteboard:
Depends On: 1226881 1231767 1271249
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-08 10:53 UTC by Nag Pavan Chilakam
Modified: 2016-09-17 15:38 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1226881
Environment:
Last Closed: 2015-06-10 13:53:57 UTC
Embargoed:


Attachments (Terms of Use)

Description Nag Pavan Chilakam 2015-06-08 10:53:14 UTC
+++ This bug was initially created as a clone of Bug #1226881 +++

Description of problem:

gcc v5.1.1 throws warning for calling a static function from a non-static inline function.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.compile with gcc v5.1.1
2.
3.

Actual results:

couple of compiler warning

Expected results:

should be free from compiler warning

Additional info:

--- Additional comment from Anand Avati on 2015-06-01 07:39:18 EDT ---

REVIEW: http://review.gluster.org/11032 (tiering:static function called from a non static inline function) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Mohammed Rafi KC on 2015-06-01 07:46:16 EDT ---



--- Additional comment from Anand Avati on 2015-06-02 01:30:00 EDT ---

REVIEW: http://review.gluster.org/11032 (tiering:static function called from a non static inline function) posted (#3) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Anand Avati on 2015-06-02 18:00:25 EDT ---

COMMIT: http://review.gluster.org/11032 committed in master by Niels de Vos (ndevos) 
------
commit 3a94f4c52b56f08c326d3212ca5708e8daf8585b
Author: Mohammed Rafi KC <rkavunga>
Date:   Mon Jun 1 16:53:32 2015 +0530

    tiering:static function called from a non static inline function
    
    gcc v5.1.1 throws warning for calling a static function from a
    non-static inline function.
    
    
    <snippet from compiler warning>
      CC       tier.lo
    tier.c:610:15: warning: 'tier_migrate_using_query_file' is static but used in inline function 'tier_migrate_files_using_qfile' which is not static
             ret = tier_migrate_using_query_file ((void *)query_cbk_args);
                   ^
    tier.c:585:47: warning: 'tier_process_brick_cbk' is static but used in inline function 'tier_build_migration_qfile' which is not static
             ret = dict_foreach (args->brick_list, tier_process_brick_cbk,
                                                   ^
    tier.c:565:176: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:565:158: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:563:58: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:563:40: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
             ret = remove (GET_QFILE_PATH (is_promotion));
                                            ^
      CCLD     tier.la
    
    </snip>
    
    Change-Id: I46046feeb79ab4e2724b0ba6b02c9ec8b121ff4e
    BUG: 1226881
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/11032
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Anoop C S <achiraya>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 2 Mohammed Rafi KC 2015-06-10 13:53:57 UTC
Since downstream build is not dependent on gcc v5.1.1, closing the bug. Fixed in upstream branch.


Note You need to log in before you can comment on or make changes to this bug.