Bug 1229272

Summary: tiering:compiler warning with gcc v5.1.1
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Nag Pavan Chilakam <nchilaka>
Component: tierAssignee: Mohammed Rafi KC <rkavunga>
Status: CLOSED WONTFIX QA Contact: Nag Pavan Chilakam <nchilaka>
Severity: urgent Docs Contact:
Priority: urgent    
Version: rhgs-3.1CC: bugs, josferna, rhs-bugs, rkavunga, storage-qa-internal
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1226881 Environment:
Last Closed: 2015-06-10 13:53:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1226881, 1231767, 1271249    
Bug Blocks:    

Description Nag Pavan Chilakam 2015-06-08 10:53:14 UTC
+++ This bug was initially created as a clone of Bug #1226881 +++

Description of problem:

gcc v5.1.1 throws warning for calling a static function from a non-static inline function.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.compile with gcc v5.1.1
2.
3.

Actual results:

couple of compiler warning

Expected results:

should be free from compiler warning

Additional info:

--- Additional comment from Anand Avati on 2015-06-01 07:39:18 EDT ---

REVIEW: http://review.gluster.org/11032 (tiering:static function called from a non static inline function) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Mohammed Rafi KC on 2015-06-01 07:46:16 EDT ---



--- Additional comment from Anand Avati on 2015-06-02 01:30:00 EDT ---

REVIEW: http://review.gluster.org/11032 (tiering:static function called from a non static inline function) posted (#3) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Anand Avati on 2015-06-02 18:00:25 EDT ---

COMMIT: http://review.gluster.org/11032 committed in master by Niels de Vos (ndevos) 
------
commit 3a94f4c52b56f08c326d3212ca5708e8daf8585b
Author: Mohammed Rafi KC <rkavunga>
Date:   Mon Jun 1 16:53:32 2015 +0530

    tiering:static function called from a non static inline function
    
    gcc v5.1.1 throws warning for calling a static function from a
    non-static inline function.
    
    
    <snippet from compiler warning>
      CC       tier.lo
    tier.c:610:15: warning: 'tier_migrate_using_query_file' is static but used in inline function 'tier_migrate_files_using_qfile' which is not static
             ret = tier_migrate_using_query_file ((void *)query_cbk_args);
                   ^
    tier.c:585:47: warning: 'tier_process_brick_cbk' is static but used in inline function 'tier_build_migration_qfile' which is not static
             ret = dict_foreach (args->brick_list, tier_process_brick_cbk,
                                                   ^
    tier.c:565:176: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:565:158: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:563:58: warning: 'demotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
    tier.c:563:40: warning: 'promotion_qfile' is static but used in inline function 'tier_build_migration_qfile' which is not static
             ret = remove (GET_QFILE_PATH (is_promotion));
                                            ^
      CCLD     tier.la
    
    </snip>
    
    Change-Id: I46046feeb79ab4e2724b0ba6b02c9ec8b121ff4e
    BUG: 1226881
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/11032
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Anoop C S <achiraya>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 2 Mohammed Rafi KC 2015-06-10 13:53:57 UTC
Since downstream build is not dependent on gcc v5.1.1, closing the bug. Fixed in upstream branch.