Bug 1229886

Summary:	Review Request: pynote - Manage notes on the commandline
Product:	[Fedora] Fedora	Reporter:	William Moreno <williamjmorenor>
Component:	Package Review	Assignee:	Ankur Sinha (FranciscoD) <sanjay.ankur>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jeremy, package-review, rumpelsepp, sanjay.ankur
Target Milestone:	---	Flags:	sanjay.ankur: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-24 02:41:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1229975, 1294537
Bug Blocks:

Description William Moreno 2015-06-09 20:58:55 UTC

Spec URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote.spec
SRPM URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote-1.0.0-1.fc22.src.rpm
Description: Manage notes on the commandline
Fedora Account System Username: williamjmorenor

Comment 1 William Moreno 2015-06-09 21:00:42 UTC

Request a manpage upstream
https://github.com/rumpelsepp/pynote/issues/33

Comment 2 Stefan Tatschner 2015-06-09 22:35:21 UTC

The manpages can be generated with "make man" in the docs directory.

Please ensure that all dependencies are present. A recent dependency list can be optained from the arch linux package [1]:

    python
    python-babel
    python-click
    python-plaintable
    python-setuptools (make)
    python-sphinx (make)
    python-pygments (optional) – synthax highlighting support


[1]: https://aur.archlinux.org/packages/pynote

Comment 3 William Moreno 2015-06-10 04:48:51 UTC

Spec URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote.spec
SRPM URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote-1.0.0-2.fc22.src.rpm

- 1.0.0-2
- Include man

Thanks I was mising a dependency:
https://bugzilla.redhat.com/show_bug.cgi?id=1229975

Comment 4 Ankur Sinha (FranciscoD) 2015-06-16 12:29:59 UTC

I'll review this.

Comment 5 William Moreno 2015-07-06 00:10:59 UTC

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/pynote.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/pynote-1.0.0-2.fc22.src.rpm

=======
Move to Fedora People

Comment 6 Jeremy Cline 2015-12-27 13:50:42 UTC

Hi William. Currently, this package will not build, so I'll just do a brief review and do a full review once it builds:

1. The BuildRequires dependency on 'python3-sphinx' is, unfortunately, not enough. The '/usr/bin/sphinx-build' binary is provided by 'python-sphinx' (the Python 2 version of the package). The 'python3-sphinx' package provides '/usr/bin/sphinx-build-3', so you can either alter the Makefile that builds the documentation, or depend on 'python-sphinx' instead.

2. Your %build and %install sections can use %py3_build and %py3_install

3. You should not manually compress the man pages, as they are compressed automatically by the build system (https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages).

4. Just so you know, you can use the '-D' flag with 'install' rather than calling 'mkdir -p' before 'install'.

Comment 7 Upstream Release Monitoring 2015-12-28 21:31:58 UTC

williamjmorenor's scratch build of pynote-1.0.0-2.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12335016

Comment 8 Upstream Release Monitoring 2015-12-28 21:37:47 UTC

williamjmorenor's scratch build of pynote-1.0.0-2.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12335034

Comment 9 Upstream Release Monitoring 2015-12-30 19:39:47 UTC

williamjmorenor's scratch build of pynote-1.0.0-2.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12349967