Bug 1229886 - Review Request: pynote - Manage notes on the commandline
Summary: Review Request: pynote - Manage notes on the commandline
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ankur Sinha (FranciscoD)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1229975 1294537
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-09 20:58 UTC by William Moreno
Modified: 2017-10-24 02:41 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-10-24 02:41:20 UTC
Type: ---
Embargoed:
sanjay.ankur: fedora-review?


Attachments (Terms of Use)

Description William Moreno 2015-06-09 20:58:55 UTC
Spec URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote.spec
SRPM URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote-1.0.0-1.fc22.src.rpm
Description: Manage notes on the commandline
Fedora Account System Username: williamjmorenor

Comment 1 William Moreno 2015-06-09 21:00:42 UTC
Request a manpage upstream
https://github.com/rumpelsepp/pynote/issues/33

Comment 2 Stefan Tatschner 2015-06-09 22:35:21 UTC
The manpages can be generated with "make man" in the docs directory.

Please ensure that all dependencies are present. A recent dependency list can be optained from the arch linux package [1]:

    python
    python-babel
    python-click
    python-plaintable
    python-setuptools (make)
    python-sphinx (make)
    python-pygments (optional) – synthax highlighting support


[1]: https://aur.archlinux.org/packages/pynote

Comment 3 William Moreno 2015-06-10 04:48:51 UTC
Spec URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote.spec
SRPM URL: http://rmsconsultoresnicaragua.com/rpmdev/pynote-1.0.0-2.fc22.src.rpm

- 1.0.0-2
- Include man

Thanks I was mising a dependency:
https://bugzilla.redhat.com/show_bug.cgi?id=1229975

Comment 4 Ankur Sinha (FranciscoD) 2015-06-16 12:29:59 UTC
I'll review this.

Comment 6 Jeremy Cline 2015-12-27 13:50:42 UTC
Hi William. Currently, this package will not build, so I'll just do a brief review and do a full review once it builds:

1. The BuildRequires dependency on 'python3-sphinx' is, unfortunately, not enough. The '/usr/bin/sphinx-build' binary is provided by 'python-sphinx' (the Python 2 version of the package). The 'python3-sphinx' package provides '/usr/bin/sphinx-build-3', so you can either alter the Makefile that builds the documentation, or depend on 'python-sphinx' instead.

2. Your %build and %install sections can use %py3_build and %py3_install

3. You should not manually compress the man pages, as they are compressed automatically by the build system (https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages).

4. Just so you know, you can use the '-D' flag with 'install' rather than calling 'mkdir -p' before 'install'.

Comment 7 Upstream Release Monitoring 2015-12-28 21:31:58 UTC
williamjmorenor's scratch build of pynote-1.0.0-2.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12335016

Comment 8 Upstream Release Monitoring 2015-12-28 21:37:47 UTC
williamjmorenor's scratch build of pynote-1.0.0-2.fc24.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12335034

Comment 9 Upstream Release Monitoring 2015-12-30 19:39:47 UTC
williamjmorenor's scratch build of pynote-1.0.0-2.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12349967


Note You need to log in before you can comment on or make changes to this bug.