Spec URL: http://rmsconsultoresnicaragua.com/rpmdev/python-plaintable.spec SRPM URL: http://rmsconsultoresnicaragua.com/rpmdev/python-plaintable-0.1.1-1.fc22.src.rpm Description: Python2 simple library to build plain text tables Fedora Account System Username: williamjmorenor
I'll review this.
William, I can't access the spec/srpm. I get a warning saying that the page has been reported as a forgery and ff doesn't let me access it. Can you please put these up in your fedorapeople account? Thanks, Ankur
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-plaintable.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-plaintable-0.1.1-1.fc22.src.rpm =========== Move to Fedora People host
Hi William. The source URL appears to be incorrect. I think you want https://pypi.python.org/packages/source/p/%{pypi_name}/%{pypi_name}-%{version}.tar.gz" rather than "https://pypi.python.org/packages/source/n/%{pypi_name}/%{pypi_name}-%{version}.tar.gz" (note the 'p' rather than the 'n').
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-plaintable.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-plaintable-0.1.1-2.fc24.src.rpm - Update Python macros - Provides both python2 and python3 subpackages - Fix source url
williamjmorenor's scratch build of python-plaintable-0.1.1-2.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12335107
Review: [+] OK [-] NA [?] Issue ** Mandatory review guidelines: ** [+] rpmlint output: [asinha@cs-as14aho-2-herts-ac-uk SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/python-plaintable.spec python2-plaintable.noarch: W: spelling-error %description -l en_US floatprecision -> float precision, float-precision, imprecision python3-plaintable.noarch: W: spelling-error %description -l en_US floatprecision -> float precision, float-precision, imprecision python-plaintable.src: W: spelling-error %description -l en_US floatprecision -> float precision, float-precision, imprecision 3 packages and 1 specfiles checked; 0 errors, 3 warnings. [asinha@cs-as14aho-2-herts-ac-uk SRPMS]$ [+] License is acceptable: appears to be MIT https://github.com/rumpelsepp/plaintable/blob/master/LICENSE [?] License field in spec is correct Should be MIT, no? [+] License files included in package %docs if included in source package [-] License files installed when any subpackage combination is installed [+] Spec written in American English [+] Spec is legible [+] Sources match upstream unless altered to fix permissibility issues Getting https://pypi.python.org/packages/source/p/plaintable/plaintable-0.1.1.tar.gz to /tmp/review/plaintable-0.1.1.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4835 100 4835 0 0 35864 0 --:--:-- --:--:-- --:--:-- 36082 dc416d957ffdc64db5c979f7cb9b54b6 /tmp/review/plaintable-0.1.1.tar.gz dc416d957ffdc64db5c979f7cb9b54b6 /home/asinha/rpmbuild/SOURCES/plaintable-0.1.1.tar.gz [+] Build succeeds on at least one primary arch [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed [+] BuildRequires correct, justified where necessary [-] Locales handled with %find_lang, not %_datadir/locale/* [-] %post, %postun call ldconfig if package contains shared .so files [+] No bundled libs [-] Relocatability is justified [+] Package owns all directories it creates [-] Package requires others for directories it uses but does not own [+] No duplication in %files unless necessary for license files [+] File permissions are sane [+] Package contains permissible code or content [-] Large docs go in -doc subpackage [+] %doc files not required at runtime [-] Static libs go in -static package/virtual Provides [-] Development files go in -devel package [-] -devel packages Require base with fully-versioned dependency, %_isa [+] No .la files [-] GUI app uses .desktop file, installs it with desktop-file-install [+] File list does not conflict with other packages' without justification [+] File names are valid UTF-8 ** Optional review guidelines: ** [-] Query upstream about including license files [-] Translations of description, summary [+] Builds in mock [+] Builds on all arches [?] Functions as described (e.g. no crashes) Please check this [-] Scriptlets are sane [-] Subpackages require base with fully-versioned dependency if sensible [-] .pc file subpackage placement is sensible [-] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin [-] Include man pages if available Naming guidelines: [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [+] Package names are sane [+] No naming conflicts [+] Spec file name matches base package name [+] Version is sane [+] Version does not contain ~ [+] Release is sane [+] %dist tag [-] Case used only when necessary [-] Renaming handled correctly Packaging guidelines: [+] Useful without external bits [+] No kmods [+] Pre-built binaries, libs removed in %prep [+] Sources contain only redistributable code or content [+] Spec format is sane [+] Package obeys FHS, except libexecdir, /run, /usr/target [+] No files in /bin, /sbin, /lib* on >= F17 [-] Programs run before FS mounting use /run instead of /var/run [-] Binaries in /bin, /sbin do not depend on files in /usr on < F17 [+] No files under /srv, /opt, /usr/local [+] Changelog in prescribed format [+] No Packager, Vendor, Copyright, PreReq tags [+] Summary does not end in a period [-] Correct BuildRoot tag on < EL6https://williamjmorenor.fedorapeople.org/rpmdev/python-plaintable-0.1.1-2.fc24.src.rpm [-] Correct %clean section on < EL6 [+] Requires correct, justified where necessary == python2-plaintable-0.1.1-2.fc24.noarch.rpm == Provides: python-plaintable = 0.1.1-2.fc24 python-plaintable(x86-64) = 0.1.1-2.fc24 python2-plaintable = 0.1.1-2.fc24 Requires: python(abi) = 2.7 == python3-plaintable-0.1.1-2.fc24.noarch.rpm == Provides: python3-plaintable = 0.1.1-2.fc24 Requires: python(abi) = 3.5 == python-plaintable-0.1.1-2.fc24.src.rpm == Provides: Requires: python-setuptools python2-devel python3-devel python3-setuptools [+] Summary, description do not use trademarks incorrectly [-] All relevant documentation is packaged, appropriately marked with %doc [-] Doc files do not drag in extra dependencies (e.g. due to +x) [-] Code compilable with gcc is compiled with gcc [-] Build honors applicable compiler flags or justifies otherwise [-] PIE used for long-running/root daemons, setuid/filecap programs [-] Useful -debuginfo package or disabled and justified [-] Package with .pc files Requires pkgconfig on < EL6 [-] No static executables [-] Rpath absent or only used for internal libs [-] Config files marked with %config(noreplace) or justified %config [-] No config files under /usr [-] Third party package manager configs acceptable, in %_docdir [-] .desktop files are sane [+] Spec uses macros consistently [+] Spec uses macros instead of hard-coded names where appropriate [-] Spec uses macros for executables only when configurability is needed [-] %makeinstall used only when alternatives don't work [-] Macros in Summary, description are expandable at srpm build time [-] Spec uses %{SOURCE#} instead of $RPM_SOURCE_DIR and %sourcedir [+] No software collections (scl) [-] Macro files named /etc/rpm/macros.%name [+] Build uses only python/perl/shell+coreutils/lua/BuildRequired langs [+] %global, not %define [-] Package translating with gettext BuildRequires it [-] Package translating with Linguist BuildRequires qt-devel [+] File ops preserve timestamps [-] Parallel make [-] No Requires(pre,post) notation [-] User, group creation handled correctly (See Packaging:UsersAndGroups) [-] Web apps go in /usr/share/%name, not /var/www [-] Conflicts are justified [+] One project per package [+] No bundled fonts [-] Patches have appropriate commentary [-] Available test suites executed in %check [-] tmpfiles.d used for /run, /run/lock on >= F15 ** Python guidelines: ** [+] Runtime Requires correct [-] Python macros declared on < EL6 [+] All .py files packaged with .pyc, .pyo counterparts [+] Includes .egg-info files/directories when generated [-] Provides/Requires properly filtered [-] Code that invokes gtk.gdk.get_pixels_array() Requires numpy Package looks good! XX APPROVED XX
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-plaintable
Thanks for the review!
python-plaintable-0.1.1-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6d04972bf
python-plaintable-0.1.1-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7125a3398d
python-plaintable-0.1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6d04972bf
python-plaintable-0.1.1-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7125a3398d
python-plaintable-0.1.1-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
python-plaintable-0.1.1-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.