Bug 1230655
| Summary: | Flash message not displayed long enough on widget import/export page | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Nandini Chandra <nachandr> | |
| Component: | UI - OPS | Assignee: | Dávid Halász <dhalasz> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nandini Chandra <nachandr> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 5.4.0 | CC: | akarol, cpelland, eclarizi, hkataria, jhardy, jprause, mpovolny, obarenbo, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.7.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ui:flash_msg:widget | |||
| Fixed In Version: | 5.7.0.0 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1291693 1344329 (view as bug list) | Environment: | ||
| Last Closed: | 2017-01-11 20:29:17 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1291693, 1291698, 1344329 | |||
|
Description
Nandini Chandra
2015-06-11 09:36:42 UTC
Verified in master.20150915141925_58436ca New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/40f6474274cc073ccbadd2fa102662eaa9ec0bcc commit 40f6474274cc073ccbadd2fa102662eaa9ec0bcc Author: Erik Clarizio <eclarizi> AuthorDate: Mon Nov 16 08:06:46 2015 -0800 Commit: Erik Clarizio <eclarizi> CommitDate: Tue Nov 17 09:33:49 2015 -0800 Fix issue with widget import flash message JSON being html escaped https://bugzilla.redhat.com/show_bug.cgi?id=1230655 app/controllers/report_controller.rb | 2 +- app/views/report/review_import.html.haml | 2 +- spec/controllers/report_controller_spec.rb | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/74f5337b2dfcd9762286aae9508fe938a8262d52 commit 74f5337b2dfcd9762286aae9508fe938a8262d52 Author: Erik Clarizio <eclarizi> AuthorDate: Tue Nov 17 09:32:37 2015 -0800 Commit: Erik Clarizio <eclarizi> CommitDate: Tue Nov 17 09:33:49 2015 -0800 Refactor post message logic for all imports https://bugzilla.redhat.com/show_bug.cgi?id=1230655 This also fixes the brakeman issue where the message was not being properly escaped app/assets/javascripts/automate_import_export.js | 23 +----- app/assets/javascripts/dialog_import_export.js | 21 ------ app/assets/javascripts/import.js | 28 ++++++++ app/assets/javascripts/widget_import_export.js | 21 ------ .../_dialog_import_export.html.haml | 2 +- app/views/miq_ae_tools/_import_export.html.haml | 2 +- app/views/report/_export_widgets.html.haml | 2 +- app/views/report/review_import.html.haml | 2 +- spec/javascripts/import_spec.js | 83 ++++++++++++++++++++++ 9 files changed, 116 insertions(+), 68 deletions(-) *** Bug 1284057 has been marked as a duplicate of this bug. *** New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b7a5a3ad53fd3d12bf4785e20b8430ec9a5484bb commit b7a5a3ad53fd3d12bf4785e20b8430ec9a5484bb Author: Erik Clarizio <eclarizi> AuthorDate: Tue Nov 17 09:32:37 2015 -0800 Commit: Erik Clarizio <eclarizi> CommitDate: Wed Dec 16 13:00:35 2015 -0800 Refactor post message logic for all imports https://bugzilla.redhat.com/show_bug.cgi?id=1230655 This also fixes the brakeman issue where the message was not being properly escaped app/assets/javascripts/automate_import_export.js | 23 +----- app/assets/javascripts/dialog_import_export.js | 21 ------ app/assets/javascripts/import.js | 28 ++++++++ app/assets/javascripts/widget_import_export.js | 21 ------ .../_dialog_import_export.html.haml | 2 +- app/views/miq_ae_tools/_import_export.html.haml | 2 +- app/views/report/_export_widgets.html.haml | 2 +- app/views/report/review_import.html.haml | 2 +- spec/javascripts/import_spec.js | 83 ++++++++++++++++++++++ 9 files changed, 116 insertions(+), 68 deletions(-) New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=aa429c262e1e3dfe693ea431e8fe6f3d3fb5f1f1 commit aa429c262e1e3dfe693ea431e8fe6f3d3fb5f1f1 Author: Erik Clarizio <eclarizi> AuthorDate: Mon Nov 16 08:06:46 2015 -0800 Commit: Erik Clarizio <eclarizi> CommitDate: Wed Dec 16 13:00:27 2015 -0800 Fix issue with widget import flash message JSON being html escaped https://bugzilla.redhat.com/show_bug.cgi?id=1230655 app/controllers/report_controller.rb | 2 +- app/views/report/review_import.html.haml | 2 +- spec/controllers/report_controller_spec.rb | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) It looks like the code has changed significantly in regards to how it handles widget importing for 5.6. New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/e7376896490c3a5c6ac8b0f3add139d11ec88935 commit e7376896490c3a5c6ac8b0f3add139d11ec88935 Author: Dávid Halász <dhalasz> AuthorDate: Fri May 27 12:00:21 2016 +0200 Commit: Dávid Halász <dhalasz> CommitDate: Tue May 31 09:18:47 2016 +0200 Suppress @in_a_form during widget upload if an error happens https://bugzilla.redhat.com/show_bug.cgi?id=1230655 app/controllers/report_controller.rb | 2 ++ spec/controllers/report_controller_spec.rb | 1 + 2 files changed, 3 insertions(+) Verified in 5.7.0.4 |