Bug 1235939

Summary:	Provide and use a common way to do reference counting of (internal) structures
Product:	[Community] GlusterFS	Reporter:	Raghavendra G <rgowdapp>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.7.2	CC:	bugs, gluster-bugs, kparthas, ndevos, rkavunga, vmallika
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1228157	Environment:
Last Closed:	2015-07-30 09:48:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1228157
Bug Blocks:	1226717, 1235628

Description Raghavendra G 2015-06-26 07:00:29 UTC

+++ This bug was initially created as a clone of Bug #1228157 +++

Description of problem:
Many structures need reference counting, and each structure implements its own way of doing it. This is confusing and makes things more difficult to understand than it necessary.

Version-Release number of selected component (if applicable):
mainline

I am not a grape farmer:
http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/11202

--- Additional comment from Anand Avati on 2015-06-04 06:48:57 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "struct gf_ref" for common refcounting strutures) posted (#3) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-04 06:49:46 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#4) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-04 07:19:00 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#5) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-04 09:45:13 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#6) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-04 19:15:08 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#7) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-16 15:58:00 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#8) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-16 16:03:23 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#9) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-06-17 05:29:26 EDT ---

REVIEW: http://review.gluster.org/11022 (core: add "gf_ref_t" for common refcounting structures) posted (#10) for review on master by Niels de Vos (ndevos)

Comment 1 Anand Avati 2015-06-26 17:01:13 UTC

REVIEW: http://review.gluster.org/11421 (core: add "gf_ref_t" for common refcounting structures) posted (#3) for review on release-3.7 by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Vijaikumar Mallikarjuna 2015-06-27 07:39:07 UTC

Patch merged: http://review.gluster.org/#/c/11421/

Comment 3 Kaushal 2015-07-30 09:48:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user