Bug 1244290

Summary: Fix invalid logic in tier.t
Product: [Community] GlusterFS Reporter: Dan Lambright <dlambrig>
Component: tieringAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: unspecified Docs Contact:
Priority: high    
Version: 3.7.3CC: bugs, skoduri
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1231268 Environment:
Last Closed: 2016-05-10 12:49:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1231268, 1252903, 1262335    
Bug Blocks: 1260923    

Description Dan Lambright 2015-07-17 16:39:32 UTC
+++ This bug was initially created as a clone of Bug #1231268 +++

The tier.t logic did not properly check for corrupted data after migration.

--- Additional comment from Anand Avati on 2015-06-17 11:15:57 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in tier.t) posted (#1) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-06-22 10:48:19 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in tier.t) posted (#2) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-06-22 13:56:08 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in tier.t) posted (#3) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-06-26 19:25:40 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in tier.t) posted (#4) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-06-29 11:32:15 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in tier.t) posted (#5) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-06-29 11:45:30 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fixed logical bug in tier.t) posted (#6) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-07-07 15:45:36 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fix for logical bugs/timing errors in tier.t) posted (#7) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-07-07 15:58:14 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fix for logical bugs/timing errors in tier.t) posted (#8) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-07-13 13:14:56 EDT ---

REVIEW: http://review.gluster.org/11285 (cluster/tier : fix for logical bugs/timing errors in tier.t) posted (#9) for review on master by Pamela Ousley (pousley)

--- Additional comment from Anand Avati on 2015-07-13 17:12:30 EDT ---

COMMIT: http://review.gluster.org/11285 committed in master by Dan Lambright (dlambrig) 
------
commit f7b9379a0a03fb1d2df56bbfc8dca06f5f3b8437
Author: Pamela Ousley <pousley>
Date:   Wed Jun 17 15:07:55 2015 -0400

    cluster/tier : fix for logical bugs/timing errors in tier.t
    
    The md5sum fingerprints were not correctly compared after moving
    files between the hot and cold tiers.
    
    This version of tier.t uses a new function, "check_counters", to
    ensure that the number of promotions/demotions is as expected.
    This is intended to avoid spurious timing-related errors that were
    seen with the old script.
    
    Change-Id: I4a0ae7315493bfd307a0f68f21fa3ea33c88b08f
    BUG: 1231268
    Signed-off-by: Pamela Ousley <pousley>
    Reviewed-on: http://review.gluster.org/11285
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 1 Anand Avati 2015-07-17 19:24:26 UTC
REVIEW: http://review.gluster.org/11715 (cluster/tier : fix for logical bugs/timing errors in tier.t) posted (#1) for review on release-3.7 by Pamela Ousley (pousley)