Bug 1245547

Summary:	sharding - Fix unlink of sparse files
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	sharding	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1247014 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:26:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1247014

Description Krutika Dhananjay 2015-07-22 09:25:19 UTC

Description of problem:
In a sharded volume, unlink of files with holes fails with ENOENT.
This is because shard_common_lookup_shards() treats absence of participant shards as failure. But in case of files with holes, it is possible for most shards to not exist. And shard translator must not fail unlinks and renames (where the dst exists && is sharded && has holes).

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-07-22 09:51:36 UTC

REVIEW: http://review.gluster.org/11737 (features/shard: Handle unlink of files with holes appropriately in unlink() and rename()) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2015-07-22 11:19:55 UTC

REVIEW: http://review.gluster.org/11737 (features/shard: Handle unlink of files with holes appropriately in unlink() and rename().) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Anand Avati 2015-07-23 01:41:48 UTC

REVIEW: http://review.gluster.org/11737 (features/shard: Handle unlink of files with holes appropriately in unlink() and rename()) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Anand Avati 2015-07-23 04:07:39 UTC

REVIEW: http://review.gluster.org/11737 (features/shard: Handle unlink of files with holes appropriately in unlink() and rename().) posted (#4) for review on master by Krutika Dhananjay (kdhananj)

Comment 5 Anand Avati 2015-07-24 01:43:11 UTC

REVIEW: http://review.gluster.org/11737 (features/shard: Handle unlink of files with holes appropriately in unlink() and rename().) posted (#5) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Anand Avati 2015-07-27 07:33:03 UTC

COMMIT: http://review.gluster.org/11737 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 385acc675c512c63f7051d46ad96666ea34cf0b5
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Jul 22 15:18:20 2015 +0530

    features/shard: Handle unlink of files with holes appropriately in unlink() and rename().
    
    Change-Id: I25a02386dc95580c2e76a13fdd8e11a0df234d56
    BUG: 1245547
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/11737
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 7 Nagaprasad Sathyanarayana 2015-10-25 15:20:08 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 8 Niels de Vos 2016-06-16 13:26:24 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user