Bug 1248521

Summary: quota : display the size equivalent to the soft limit percentage in gluster v quota <volname> list* command
Product: [Community] GlusterFS Reporter: Manikandan <mselvaga>
Component: quotaAssignee: Manikandan <mselvaga>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: low    
Version: mainlineCC: bugs, gluster-bugs, smohan
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1255644 1271184 (view as bug list) Environment:
Last Closed: 2016-06-16 13:28:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1255644, 1271184    

Description Manikandan 2015-07-30 12:54:01 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Manikandan 2015-07-30 12:59:15 UTC
Use case 1:

Currently, the "gluster v quota <volname> list <path>" outputs

For eg..,

[root@dhcp35-94 test]# gluster v quota vol1 list
                  Path                   Hard-limit  Soft-limit      Used  Available  Soft-limit exceeded? Hard-limit exceeded?
-------------------------------------------------------------------------------------------------------------------------------
/dir                                       5.0MB     80%          0Bytes   5.0MB              No                   No

Use case 2:

Also for "gluster v quota <volname> list-objects <path>" outputs,

For eg..,

[root@dhcp35-94 test]# gluster v quota vol1 list-objects /dir
                  Path                   Hard-limit   Soft-limit      Files       Dirs     Available  Soft-limit exceeded? Hard-limit exceeded?
-----------------------------------------------------------------------------------------------------------------------------------------------
/dir                                            10       80%          0          1          9              No                   No


It would be better if we could display the 80% soft limit equivalent value of the hard limit.

Comment 2 Anand Avati 2015-07-30 13:06:45 UTC
REVIEW: http://review.gluster.org/11808 (quota : display the size of soft limit percentage) posted (#1) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 3 Manikandan 2015-07-30 13:17:12 UTC
With the above patch, 

"gluster v quota <volname> list <path>" command outputs,

[root@dhcp35-94 test]# gluster v quota vol1 list
                  Path                   Hard-limit  Soft-limit      Used  Available  Soft-limit exceeded? Hard-limit exceeded?
-------------------------------------------------------------------------------------------------------------------------------
/dir                                       1.0GB     60%(614.4MB)   0Bytes   1.0GB              No                   No

"gluster v quota <volname> list-objects <path>" command shows,

[root@dhcp35-94 test]# gluster v quota vol1 list-objects /dir
                  Path                   Hard-limit   Soft-limit      Files       Dirs     Available  Soft-limit exceeded? Hard-limit exceeded?
-----------------------------------------------------------------------------------------------------------------------------------------------
/dir                                            10       80%(8)          0          1          9              No                   No

Comment 4 Anand Avati 2015-07-31 06:05:38 UTC
REVIEW: http://review.gluster.org/11808 (quota : display the size of soft limit percentage) posted (#2) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 5 Anand Avati 2015-08-03 03:29:14 UTC
REVIEW: http://review.gluster.org/11808 (quota : display the size of soft limit percentage) posted (#3) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 6 Anand Avati 2015-08-04 13:06:01 UTC
REVIEW: http://review.gluster.org/11808 (quota : display the size of soft limit percentage) posted (#4) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 7 Anand Avati 2015-08-12 07:29:03 UTC
REVIEW: http://review.gluster.org/11808 (quota : display the size of soft limit percentage) posted (#5) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 8 Anand Avati 2015-08-12 10:27:58 UTC
REVIEW: http://review.gluster.org/11808 (quota :display the size of soft limit percentage) posted (#6) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 9 Anand Avati 2015-08-13 05:12:47 UTC
REVIEW: http://review.gluster.org/11808 (quota :display the size of soft limit percentage) posted (#7) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 10 Anand Avati 2015-08-17 11:08:22 UTC
REVIEW: http://review.gluster.org/11808 (quota :display the size of soft limit percentage) posted (#8) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 11 Anand Avati 2015-08-20 11:11:23 UTC
REVIEW: http://review.gluster.org/11808 (quota :display the size of soft limit percentage) posted (#9) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 12 Vijay Bellur 2015-10-12 09:38:08 UTC
REVIEW: http://review.gluster.org/12337 (cli : freeing the allocated memory) posted (#1) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 13 Vijay Bellur 2015-10-12 12:27:48 UTC
REVIEW: http://review.gluster.org/12337 (cli : freeing the allocated memory) posted (#2) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 14 Vijay Bellur 2015-10-14 07:00:02 UTC
COMMIT: http://review.gluster.org/12337 committed in master by Kaushal M (kaushal) 
------
commit a2976a2eb8c79cbec1009bec4c420b4874da25bc
Author: Manikandan Selvaganesh <mselvaga>
Date:   Mon Oct 12 15:03:28 2015 +0530

    cli : freeing the allocated memory
    
    Change-Id: Ibcbad94c091a9c24fe5aff2d7e8bcd9ac88da7bf
    BUG: 1248521
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/12337
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
    Reviewed-by: Kaushal M <kaushal>

Comment 15 Nagaprasad Sathyanarayana 2015-10-25 15:11:22 UTC
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 16 Niels de Vos 2016-06-16 13:28:07 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user