Bug 1249191

Summary: trace-cmd record crashes if -f is used before -e
Product: Red Hat Enterprise Linux 7 Reporter: Daniel Bristot de Oliveira <daolivei>
Component: trace-cmdAssignee: John Kacur <jkacur>
Status: CLOSED ERRATA QA Contact: Ziqian SUN (Zamir) <zsun>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.2CC: bhu, jkacur, jkastner, lilu, williams
Target Milestone: rcKeywords: Reopened
Target Release: 7.3   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1249194 (view as bug list) Environment:
Last Closed: 2016-11-04 08:07:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1249194, 1274397, 1282960, 1313485    

Description Daniel Bristot de Oliveira 2015-07-31 18:57:57 UTC 
Description of problem:
The trace-cmd record command is crashing if a -f filter is used before
a -e event.

The usage a -f before a -e is a command line error, and trace-cmd
record detects this error by checking if the last_event pointer is NULL.

However, the last_event is not initialized as NULL and this command line
error is not detected. Then, the last_event is used to save the filter
options and this causes a segmentation fault because last_event was not
initialized yet.

Version-Release number of selected component (if applicable):
trace-cmd-2.2.1-6.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. # trace-cmd record -f foo

Actual results:
  # trace-cmd record -f foo
  Segmentation fault

Expected results:
  # trace-cmd record -f foo
  filter must come after event

Additional info:
  upstream patch proposed: https://lkml.org/lkml/2015/7/20/482
Comment 3 John Kacur 2015-11-18 00:01:53 UTC 
Tested-by: John Kacur <jkacur> sent upstream, will apply here.
Comment 11 errata-xmlrpc 2016-11-04 08:07:24 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2531.html