Bug 125104
Summary: | problem running url launcher of the desktop | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Roi Illouz <chaye> | ||||
Component: | nautilus | Assignee: | Alexander Larsson <alexl> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||
Severity: | low | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 2 | CC: | cefrodrigues, sitsofe | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i686 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2004-10-12 10:34:00 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Roi Illouz
2004-06-02 18:53:54 UTC
Created attachment 101764 [details]
Adds the .desktop extension to links
The links are broken because the file gets no .desktop extension. This patch
adds the .desktop extension to URL links, thus fixing the problem.
This is very strange. The contents of the desktop file should be enought to get it recognized as such. *** Bug 126279 has been marked as a duplicate of this bug. *** The patch is wrong btw. This is a very lowlevel function that creates a file with a given filename. It should not create a file with a different filename. All sorts of things will break. If adding .desktop is right in this case we should do that at the place where we accept mozilla drops. The contents should be enough but when the file ends up with an extension other than .desktop, it takes precedence over the content. Since the .desktop extension doesn't show, I see no problem in just adding it in the appropriate place. I'm not saying when doing that operation you shouldn't add desktop. Just that its the wrong place in the code to do so. It will break code that expects that when you create "foo.desktop" with this API, a file called "foo.desktop" appears, not "foo.desktop.desktop". I wasn't defending the correctness of my patch, I see why it isn't good (although I fail see a point in having a ".desktop" file not ending in ".desktop" as these functions allow) but I've been looking into this and I don't really know how to do this without being invasive. If the ".desktop" part is added some levels above, where nautilus accepts the URL drop, the link ends up with "Name=" ending in ".desktop", because the "Name=" is assumed to be the same as the name of the file being created. *** Bug 127444 has been marked as a duplicate of this bug. *** Fixed in 2.8.1-2 |