Bug 1251042

Summary:	while re-configuring the scrubber frequency, scheduling is not happening based on current time
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	bitrot	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	mainline	CC:	annair, asrivast, avishwan, nsathyan, rmekala, ssaha, vbellur, vshankar
Target Milestone:	---	Keywords:	Reopened, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1226995
Clones:	1253160 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:29:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1226995, 1232307
Bug Blocks:	1216951, 1253160

Comment 1 Kotresh HR 2015-08-06 12:59:21 UTC

Description of problem:
==============================
while re-configuring the scrubber frequency, scheduling is not happening based on current time 


Version-Release number of selected component (if applicable):
=====================
mainline



How reproducible:


Steps to Reproduce:
====================
1.Create a volume and enable bitrot
2.After some time change the scrubber frequency to hourly but scheduling is happening based on bitrot enable time of the volume not from current time
3.

Actual results:


Expected results:
=====================
while re-configuring the scrubber frequency, scheduling should happen based current time

Comment 2 Anand Avati 2015-08-06 13:02:18 UTC

REVIEW: http://review.gluster.org/11853 (features/bitrot: Fix rescheduling scrub-frequency) posted (#1) for review on master by Kotresh HR (khiremat)

Comment 3 Anand Avati 2015-08-07 07:13:56 UTC

REVIEW: http://review.gluster.org/11853 (features/bitrot: Fix rescheduling scrub-frequency) posted (#2) for review on master by Kotresh HR (khiremat)

Comment 4 Anand Avati 2015-08-13 05:38:16 UTC

COMMIT: http://review.gluster.org/11853 committed in master by Venky Shankar (vshankar) 
------
commit 1d0968d5acd10188d4684bfb1d345c72ccefa75a
Author: Kotresh HR <khiremat>
Date:   Thu Aug 6 16:53:22 2015 +0530

    features/bitrot: Fix rescheduling scrub-frequency
    
    While rescheduling scrub frequency, boot time of
    the brick was considered where it is not required
    and also delta is calculated using unsigned int
    resulting in the loss of fractional part leading to
    wrong scrub frequency. Boot time is completely
    removed and delta calculation is simplified.
    
    Change-Id: If54697389f663afc86408dc8a01a3ea07e00f2dc
    BUG: 1251042
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/11853
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>

Comment 5 Nagaprasad Sathyanarayana 2015-10-25 15:06:14 UTC

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

Comment 6 Niels de Vos 2016-06-16 13:29:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user