Bug 1252050

Summary:	Rewrite pcsd launch script
Product:	Red Hat Enterprise Linux 7	Reporter:	Radek Steiger <rsteiger>
Component:	pcs	Assignee:	Ondrej Mular <omular>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	7.2	CC:	cluster-maint, idevat, jpokorny, tojeline
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pcs-0.9.151-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-03 20:55:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Radek Steiger 2015-08-10 14:43:58 UTC

> Description of problem:

While the current /usr/lib/pcsd/pcsd launch script in RHEL7 is based on a standard iniscript skeleton it doesn't work that way.  

When the start() is issued, instead of sending the ruby process into the background the script is kept running and ruby is spawned as a child of this script. As soon as systemd sends the TERM signal to the script to stop pcsd, it tries to terminate the child process tree as well. This often leads to the TERM signal being caugth twice in ruby resulting in a traceback:

Shutting down (TERM)
Shutting down (TERM)
/usr/lib/pcsd/vendor/bundle/ruby/gems/rack-1.6.4/lib/rack/handler/webrick.rb:48:in `shutdown': undefined method `shutdown' for nil:NilClass (NoMethodError)
        from /usr/lib/pcsd/ssl.rb:56:in `block in <main>'
        from /usr/share/ruby/webrick/log.rb:150:in `call'
        from /usr/share/ruby/webrick/log.rb:150:in `strftime'
        from /usr/share/ruby/webrick/log.rb:150:in `log'
        from /usr/share/ruby/webrick/log.rb:94:in `info'
        from /usr/share/ruby/webrick/server.rb:197:in `block in start'
        from /usr/share/ruby/webrick/server.rb:32:in `start'
        from /usr/share/ruby/webrick/server.rb:160:in `start'
        from /usr/lib/pcsd/vendor/bundle/ruby/gems/rack-1.6.4/lib/rack/handler/webrick.rb:34:in `run'
        from /usr/lib/pcsd/ssl.rb:62:in `<main>

I've tried disabling the termination of children processes in systemd, but it introduces a different issue with the ruby process getting stuck when the stop is issued shortly after startup.

Also, there's a stop() function in the startup script which doesn't seem to be doing anything at all and therefore cannot be used by systemd to shutdown pcsd correctly.


> Version-Release number of selected component (if applicable):

pcs-0.9.142-2.el7.x86_64


> Expected results:

We need either to rewrite the script so it can work a fully-feature iniscript or call pcsd daemon directly from systemd.

Comment 1 Ondrej Mular 2015-10-22 19:18:25 UTC

upstream patch:
https://github.com/feist/pcs/commit/b67ef27f540b857e1c2ce6e49bdcfa83744467d8

Comment 2 Tomas Jelinek 2016-03-07 15:30:28 UTC

*** Bug 1315353 has been marked as a duplicate of this bug. ***

Comment 3 Mike McCune 2016-03-28 23:15:27 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 4 Ivan Devat 2016-05-31 12:16:36 UTC

Before fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.143-15.el7.x86_64

[vm-rhel72-1 ~] $ service pcsd status
Redirecting to /bin/systemctl status  pcsd.service
● pcsd.service - PCS GUI and remote configuration interface
   Loaded: loaded (/usr/lib/systemd/system/pcsd.service; disabled; vendor preset: disabled)
   Active: active (running) since Ne 2016-05-29 00:11:56 CEST; 53min ago
 Main PID: 24025 (pcsd)
   CGroup: /system.slice/pcsd.service
           ├─24025 /bin/sh /usr/lib/pcsd/pcsd start
           ├─24030 /bin/bash -c ulimit -S -c 0 >/dev/null 2>&1 ; /usr/bin/ruby -I/usr/lib/pcsd /usr/lib/pcsd/ssl.rb
           └─24031 /usr/bin/ruby -I/usr/lib/pcsd /usr/lib/pcsd/ssl.rb

kvě 29 00:11:56 vm-rhel72-1 systemd[1]: Starting PCS GUI and remote configuration interface...
kvě 29 00:11:56 vm-rhel72-1 systemd[1]: Started PCS GUI and remote configuration interface.


After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.151-1.el7.x86_64

[vm-rhel72-1 ~] $ service pcsd status
Redirecting to /bin/systemctl status  pcsd.service
● pcsd.service - PCS GUI and remote configuration interface
   Loaded: loaded (/usr/lib/systemd/system/pcsd.service; disabled; vendor preset: disabled)
   Active: active (running) since Ne 2016-05-29 01:05:11 CEST; 3s ago
 Main PID: 1844 (ruby)
   CGroup: /system.slice/pcsd.service
           └─1844 /usr/bin/ruby -C/var/lib/pcsd -I/usr/lib/pcsd -- /usr/lib/pcsd/ssl.rb > /dev/null &

kvě 29 01:05:11 vm-rhel72-1 systemd[1]: Started PCS GUI and remote configuration interface.
kvě 29 01:05:11 vm-rhel72-1 systemd[1]: Starting PCS GUI and remote configuration interface...

Comment 8 errata-xmlrpc 2016-11-03 20:55:09 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html