RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1252050 - Rewrite pcsd launch script
Summary: Rewrite pcsd launch script
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.2
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: ---
Assignee: Ondrej Mular
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
: 1315353 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-08-10 14:43 UTC by Radek Steiger
Modified: 2016-11-03 20:55 UTC (History)
4 users (show)

Fixed In Version: pcs-0.9.151-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 20:55:09 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1247818 0 medium CLOSED pcs depends on initscripts 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1258619 0 high CLOSED Ruby traceback on pcsd startup - /webrick.rb:48:in `shutdown': undefined method `shutdown' 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1348579 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Product Errata RHSA-2016:2596 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2016-11-03 12:11:34 UTC

Internal Links: 1247818 1258619 1348579

Description Radek Steiger 2015-08-10 14:43:58 UTC 
> Description of problem:

While the current /usr/lib/pcsd/pcsd launch script in RHEL7 is based on a standard iniscript skeleton it doesn't work that way.  

When the start() is issued, instead of sending the ruby process into the background the script is kept running and ruby is spawned as a child of this script. As soon as systemd sends the TERM signal to the script to stop pcsd, it tries to terminate the child process tree as well. This often leads to the TERM signal being caugth twice in ruby resulting in a traceback:

Shutting down (TERM)
Shutting down (TERM)
/usr/lib/pcsd/vendor/bundle/ruby/gems/rack-1.6.4/lib/rack/handler/webrick.rb:48:in `shutdown': undefined method `shutdown' for nil:NilClass (NoMethodError)
        from /usr/lib/pcsd/ssl.rb:56:in `block in <main>'
        from /usr/share/ruby/webrick/log.rb:150:in `call'
        from /usr/share/ruby/webrick/log.rb:150:in `strftime'
        from /usr/share/ruby/webrick/log.rb:150:in `log'
        from /usr/share/ruby/webrick/log.rb:94:in `info'
        from /usr/share/ruby/webrick/server.rb:197:in `block in start'
        from /usr/share/ruby/webrick/server.rb:32:in `start'
        from /usr/share/ruby/webrick/server.rb:160:in `start'
        from /usr/lib/pcsd/vendor/bundle/ruby/gems/rack-1.6.4/lib/rack/handler/webrick.rb:34:in `run'
        from /usr/lib/pcsd/ssl.rb:62:in `<main>

I've tried disabling the termination of children processes in systemd, but it introduces a different issue with the ruby process getting stuck when the stop is issued shortly after startup.

Also, there's a stop() function in the startup script which doesn't seem to be doing anything at all and therefore cannot be used by systemd to shutdown pcsd correctly.


> Version-Release number of selected component (if applicable):

pcs-0.9.142-2.el7.x86_64


> Expected results:

We need either to rewrite the script so it can work a fully-feature iniscript or call pcsd daemon directly from systemd.
Comment 1 Ondrej Mular 2015-10-22 19:18:25 UTC 
upstream patch:
https://github.com/feist/pcs/commit/b67ef27f540b857e1c2ce6e49bdcfa83744467d8
Comment 2 Tomas Jelinek 2016-03-07 15:30:28 UTC 
*** Bug 1315353 has been marked as a duplicate of this bug. ***
Comment 3 Mike McCune 2016-03-28 23:15:27 UTC 
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Comment 4 Ivan Devat 2016-05-31 12:16:36 UTC 
Before fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.143-15.el7.x86_64

[vm-rhel72-1 ~] $ service pcsd status
Redirecting to /bin/systemctl status  pcsd.service
● pcsd.service - PCS GUI and remote configuration interface
   Loaded: loaded (/usr/lib/systemd/system/pcsd.service; disabled; vendor preset: disabled)
   Active: active (running) since Ne 2016-05-29 00:11:56 CEST; 53min ago
 Main PID: 24025 (pcsd)
   CGroup: /system.slice/pcsd.service
           ├─24025 /bin/sh /usr/lib/pcsd/pcsd start
           ├─24030 /bin/bash -c ulimit -S -c 0 >/dev/null 2>&1 ; /usr/bin/ruby -I/usr/lib/pcsd /usr/lib/pcsd/ssl.rb
           └─24031 /usr/bin/ruby -I/usr/lib/pcsd /usr/lib/pcsd/ssl.rb

kvě 29 00:11:56 vm-rhel72-1 systemd[1]: Starting PCS GUI and remote configuration interface...
kvě 29 00:11:56 vm-rhel72-1 systemd[1]: Started PCS GUI and remote configuration interface.


After Fix:
[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.151-1.el7.x86_64

[vm-rhel72-1 ~] $ service pcsd status
Redirecting to /bin/systemctl status  pcsd.service
● pcsd.service - PCS GUI and remote configuration interface
   Loaded: loaded (/usr/lib/systemd/system/pcsd.service; disabled; vendor preset: disabled)
   Active: active (running) since Ne 2016-05-29 01:05:11 CEST; 3s ago
 Main PID: 1844 (ruby)
   CGroup: /system.slice/pcsd.service
           └─1844 /usr/bin/ruby -C/var/lib/pcsd -I/usr/lib/pcsd -- /usr/lib/pcsd/ssl.rb > /dev/null &

kvě 29 01:05:11 vm-rhel72-1 systemd[1]: Started PCS GUI and remote configuration interface.
kvě 29 01:05:11 vm-rhel72-1 systemd[1]: Starting PCS GUI and remote configuration interface...
Comment 8 errata-xmlrpc 2016-11-03 20:55:09 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2596.html
Note You need to log in before you can comment on or make changes to this bug.