Bug 1256283

Summary:	[remove-brick]: Creation of file from NFS writes to the decommissioned subvolume and subsequent lookup from fuse creates a link
Product:	[Community] GlusterFS	Reporter:	Susant Kumar Palai <spalai>
Component:	distribute	Assignee:	Susant Kumar Palai <spalai>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	amukherj, bugs, gluster-bugs, nbalacha, nsathyan, rgowdapp, rhinduja, rhs-bugs, spalai, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1232378	Environment:
Last Closed:	2015-09-09 09:40:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1225452, 1232378
Bug Blocks:	1223636, 1227687

Comment 1 Anand Avati 2015-08-24 09:39:55 UTC

REVIEW: http://review.gluster.org/11999 (dht: block/handle create op falling to decommissioned brick) posted (#1) for review on release-3.7 by Susant Palai (spalai)

Comment 2 Anand Avati 2015-08-25 09:58:04 UTC

REVIEW: http://review.gluster.org/12001 (dht: block/handle create op falling to decommissioned brick) posted (#2) for review on release-3.7 by Susant Palai (spalai)

Comment 3 Anand Avati 2015-08-27 04:56:17 UTC

COMMIT: http://review.gluster.org/12001 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 6aa0e72198e83d6dd849027fd3d0038037810065
Author: Susant Palai <spalai>
Date:   Tue Jun 16 20:35:46 2015 +0530

    dht: block/handle create op falling to decommissioned brick
    
    Problem:
    Post remove-brick start till commit phase, the client layout
    may not be in sync with disk layout because of lack of lookup.
    Hence,a create call may fall on the decommissioned brick.
    
    Solution:
    Will acquire a lock on hashed subvol. So that a fix-layout or
    selfheal can not step on layout while reading the layout.
    
    Even if we read a layout before remove-brick fix-layout and the
    file falls on the decommissioned brick, the file should be
    migrated to a new brick as per the fix-layout.
    
    BUG: 1256283
    Change-Id: I3ef1adaf20dfb9524396a3648d1a664464eda8c1
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: http://review.gluster.org/11260
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: http://review.gluster.org/12001

Comment 4 Kaushal 2015-09-09 09:40:22 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.

glusterfs-3.7.4 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12496
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user