Bug 1232378 - [remove-brick]: Creation of file from NFS writes to the decommissioned subvolume and subsequent lookup from fuse creates a link
Summary: [remove-brick]: Creation of file from NFS writes to the decommissioned subvo...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Susant Kumar Palai
QA Contact:
URL:
Whiteboard:
: 1227687 (view as bug list)
Depends On: 1225452
Blocks: 1223636 1227687 1256283
TreeView+ depends on / blocked
 
Reported: 2015-06-16 15:15 UTC by Susant Kumar Palai
Modified: 2017-08-28 10:01 UTC (History)
10 users (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of: 1225452
: 1256283 (view as bug list)
Environment:
Last Closed: 2016-06-16 13:12:44 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Comment 1 Anand Avati 2015-06-16 15:18:21 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#2) for review on master by Susant Palai (spalai)
Comment 2 Anand Avati 2015-06-18 17:34:46 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#3) for review on master by Susant Palai (spalai)
Comment 3 Anand Avati 2015-06-22 09:34:10 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#4) for review on master by Susant Palai (spalai)
Comment 4 Anand Avati 2015-07-30 07:14:21 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#5) for review on master by Susant Palai (spalai)
Comment 5 Anand Avati 2015-07-31 09:03:12 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#6) for review on master by Susant Palai (spalai)
Comment 6 Anand Avati 2015-08-04 07:26:14 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#7) for review on master by Susant Palai (spalai)
Comment 7 Anand Avati 2015-08-04 10:36:11 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#8) for review on master by Susant Palai (spalai)
Comment 8 Anand Avati 2015-08-06 13:04:11 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#9) for review on master by Susant Palai (spalai)
Comment 9 Anand Avati 2015-08-10 06:53:32 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#10) for review on master by Susant Palai (spalai)
Comment 10 Anand Avati 2015-08-12 09:10:24 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#11) for review on master by Susant Palai (spalai)
Comment 11 Anand Avati 2015-08-13 07:38:22 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#12) for review on master by Susant Palai (spalai)
Comment 12 Anand Avati 2015-08-18 06:34:23 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#13) for review on master by Susant Palai (spalai)
Comment 13 Anand Avati 2015-08-18 07:03:11 UTC 
REVIEW: http://review.gluster.org/11260 (dht: block/handle create op falling to decommissioned brick) posted (#14) for review on master by Susant Palai (spalai)
Comment 14 Anand Avati 2015-08-24 06:06:43 UTC 
COMMIT: http://review.gluster.org/11260 committed in master by Raghavendra G (rgowdapp) 
------
commit 1626fb105c99ef623be3687f3f48d9247ab9b7c4
Author: Susant Palai <spalai>
Date:   Tue Jun 16 20:35:46 2015 +0530

    dht: block/handle create op falling to decommissioned brick
    
    Problem:
    Post remove-brick start till commit phase, the client layout
    may not be in sync with disk layout because of lack of lookup.
    Hence,a create call may fall on the decommissioned brick.
    
    Solution:
    Will acquire a lock on hashed subvol. So that a fix-layout or
    selfheal can not step on layout while reading the layout.
    
    Even if we read a layout before remove-brick fix-layout and the
    file falls on the decommissioned brick, the file should be
    migrated to a new brick as per the fix-layout.
    
    Change-Id: If84a12ec34f981adb2b9b224e80f535cfe5bf9f2
    BUG: 1232378
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: http://review.gluster.org/11260
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
Comment 15 Nagaprasad Sathyanarayana 2015-10-25 15:07:42 UTC 
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.
Comment 16 Niels de Vos 2016-06-16 13:12:44 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user
Comment 17 Nithya Balachandran 2017-08-28 10:01:09 UTC 
*** Bug 1227687 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.