Bug 1257709

Summary: Copy NFS-Ganesha export files as part of volume snapshot creation
Product: [Community] GlusterFS Reporter: Jiffin <jthottan>
Component: snapshotAssignee: Jiffin <jthottan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: high    
Version: mainlineCC: asriram, asrivast, bugs, kkeithle, mzywusko, ndevos, nlevinki, rcyriac, rjoseph, sankarshan, skoduri, smohan, storage-qa-internal
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: All   
Whiteboard:
Fixed In Version: glusterfs-3.8rc2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1246007
: 1257710 (view as bug list) Environment:
Last Closed: 2016-06-16 13:33:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1216951, 1246007, 1256227, 1257710, 1261444    
Deadline: 2015-08-28   

Comment 1 Anand Avati 2015-08-27 18:19:19 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#1) for review on master by jiffin tony Thottan (jthottan)

Comment 2 Vijay Bellur 2015-09-04 08:59:36 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#2) for review on master by jiffin tony Thottan (jthottan)

Comment 3 Vijay Bellur 2015-09-04 13:11:35 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#3) for review on master by jiffin tony Thottan (jthottan)

Comment 4 Vijay Bellur 2015-09-11 08:49:40 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#4) for review on master by jiffin tony Thottan (jthottan)

Comment 5 Vijay Bellur 2015-09-15 12:10:01 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#5) for review on master by jiffin tony Thottan (jthottan)

Comment 6 Vijay Bellur 2015-10-12 06:38:18 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#6) for review on master by jiffin tony Thottan (jthottan)

Comment 7 Vijay Bellur 2015-10-14 13:01:35 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#7) for review on master by jiffin tony Thottan (jthottan)

Comment 8 Vijay Bellur 2015-10-16 05:13:00 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#8) for review on master by jiffin tony Thottan (jthottan)

Comment 9 Vijay Bellur 2015-10-27 12:06:44 UTC
REVIEW: http://review.gluster.org/12034 (snapshot : copying nfs-ganesha export file) posted (#9) for review on master by jiffin tony Thottan (jthottan)

Comment 10 Vijay Bellur 2015-10-30 20:39:55 UTC
COMMIT: http://review.gluster.org/12034 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 5583bac79851d24f0a552478b361049fe63c32b7
Author: Jiffin Tony Thottan <jthottan>
Date:   Thu Aug 27 23:26:40 2015 +0530

    snapshot : copying nfs-ganesha export file
    
    While taking snapshot, the export file used by the volume should
    copy to snap directory. So that when restore of snapshot happens,
    the volume can retain all its configuration for exporting via
    nfs-ganesha. The export file is stored at "/etc/ganesha/export" in
    the following format "export.<volname>.conf"
    
    The fix handles given cases in the following manner :
    
    case a: The nfs-ganesha(global) is ON during snapshot and restore.
            i.) Volume was exported during snapshot. When we restore snapshot,
                then volume should be exported back with old configuration file.
            ii.) Volume was unexported during snapshot. When we restore snapshot,
                 then volume should unexported again.
    
    case b: The nfs-ganesha is ON during snapshot and OFF during restore
            Volume was exported during snapshot. When we restore snapshot, the
            conf will be copied to corresponding location and if nfs-ganesha enabled
            again, then volume will be exported.
    
    For the clones, export conf file will created in /etc/ganesha/export and then
    export it via ganesha.
    
    Change-Id: Ideecda15bd4db58e991cf6c8de7bb93f3db6cd20
    BUG: 1257709
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/12034
    Reviewed-by: Avra Sengupta <asengupt>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 11 Niels de Vos 2016-06-16 13:33:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user