Bug 1265238

Summary: ss returns zero (ok) when invalid option is added
Product: Red Hat Enterprise Linux 7 Reporter: Jaroslav Aster <jaster>
Component: iprouteAssignee: Phil Sutter <psutter>
Status: CLOSED ERRATA QA Contact: Jaroslav Aster <jaster>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3   
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: iproute-3.10.0-57.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1265240 (view as bug list) Environment:
Last Closed: 2016-11-03 23:34:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1301628, 1313485    

Description Jaroslav Aster 2015-09-22 12:53:08 UTC 
Description of problem:

ss returns zero (ok) when invalid option is added.


Version-Release number of selected component (if applicable):

iproute-3.10.0-54.el7


How reproducible:

100%


Steps to Reproduce:

# ss --blabla && echo "OK" || echo "FAIL"
ss: unrecognized option '--blabla'
...
OK


Actual results:

Program returns zero.


Expected results:

Program returns non-zero.


Additional info:
Comment 1 Phil Sutter 2015-10-15 19:09:18 UTC 
Bug is consistent with upstream, patch sent:

http://marc.info/?l=linux-netdev&m=144493568522690&w=2
Comment 2 Phil Sutter 2016-01-12 17:17:12 UTC 
The following upstream commit needs to be backported:

commit f73105ab42795422f131fb711712e3c860df982f
Author: Phil Sutter <phil>
Date:   Thu Oct 15 21:01:16 2015 +0200

    ss: return -1 if an unrecognized option was given
    
    When getopt_long encounters an option which has not been registered, it
    returns '?'. React upon that and call usage() instead of help() so ss
    returns with a non-zero exit status.
    
    Signed-off-by: Phil Sutter <phil>
Comment 7 errata-xmlrpc 2016-11-03 23:34:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2162.html