Bug 1266743

Summary: [abrt] filezilla: XKeysymToKeycode(): filezilla killed by SIGSEGV
Product: [Fedora] Fedora Reporter: František Zatloukal <fzatlouk>
Component: wxGTK3Assignee: Scott Talbert <swt>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: alexandruz, alexjnewt, bugzilla, danielpgb_vasquez, el, fedora, fiedler_matthias, jotodd, k.h.hoetzel, kwizart, mclasen, noobusinghacks, ofourdan, securlogs, swt
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/6d337666dc2129a3fb847fea28595348c55dffc9
Whiteboard: abrt_hash:a9fc5bbf361b73a051f0af52d7f07062e36aca5f;VARIANT_ID=workstation;
Fixed In Version: wxGTK3-3.0.2-23.fc25 wxGTK3-3.0.2-23.fc24 wxGTK3-3.0.2-23.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-23 10:19:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1277927    
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: environ
none
File: exploitable
none
File: limits
none
File: maps
none
File: mountinfo
none
File: namespaces
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages none

Description František Zatloukal 2015-09-27 09:15:32 UTC 
Description of problem:
1. Run FileZilla in Wayland

Version-Release number of selected component:
filezilla-3.12.0.2-1.fc23

Additional info:
reporter:       libreport-2.6.2
backtrace_rating: 4
cmdline:        filezilla
crash_function: XKeysymToKeycode
executable:     /usr/bin/filezilla
global_pid:     3938
kernel:         4.2.1-300.fc23.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 XKeysymToKeycode at XKBBind.c:157
 #1 wxGetKeyState at src/unix/utilsx11.cpp:823
 #2 wxListCtrlEx::ReadColumnWidths at listctrlex.cpp:532
 #3 wxListCtrlEx::LoadColumnSettings at listctrlex.cpp:436
 #4 CQueueViewBase::CreateColumns at queue.cpp:1199
 #5 CQueueView::CQueueView at QueueView.cpp:457
 #6 CQueue::CQueue at queue.cpp:1463
 #7 CMainFrame::CMainFrame at Mainfrm.cpp:348
 #8 CFileZillaApp::OnInit at FileZilla.cpp:248
 #9 wxEntry at src/common/init.cpp:479
Comment 1 František Zatloukal 2015-09-27 09:15:36 UTC 
Created attachment 1077626 [details]
File: backtrace
Comment 2 František Zatloukal 2015-09-27 09:15:37 UTC 
Created attachment 1077627 [details]
File: cgroup
Comment 3 František Zatloukal 2015-09-27 09:15:39 UTC 
Created attachment 1077628 [details]
File: core_backtrace
Comment 4 František Zatloukal 2015-09-27 09:15:41 UTC 
Created attachment 1077629 [details]
File: dso_list
Comment 5 František Zatloukal 2015-09-27 09:15:42 UTC 
Created attachment 1077630 [details]
File: environ
Comment 6 František Zatloukal 2015-09-27 09:15:44 UTC 
Created attachment 1077631 [details]
File: exploitable
Comment 7 František Zatloukal 2015-09-27 09:15:45 UTC 
Created attachment 1077632 [details]
File: limits
Comment 8 František Zatloukal 2015-09-27 09:15:48 UTC 
Created attachment 1077633 [details]
File: maps
Comment 9 František Zatloukal 2015-09-27 09:15:49 UTC 
Created attachment 1077634 [details]
File: mountinfo
Comment 10 František Zatloukal 2015-09-27 09:15:51 UTC 
Created attachment 1077635 [details]
File: namespaces
Comment 11 František Zatloukal 2015-09-27 09:15:53 UTC 
Created attachment 1077636 [details]
File: open_fds
Comment 12 František Zatloukal 2015-09-27 09:15:54 UTC 
Created attachment 1077637 [details]
File: proc_pid_status
Comment 13 František Zatloukal 2015-09-27 09:15:56 UTC 
Created attachment 1077638 [details]
File: var_log_messages
Comment 14 Heiko Adams 2015-12-04 08:58:31 UTC 
I can confirm this issue.
Comment 15 Olivier Fourdan 2015-12-22 13:59:46 UTC 
Looks like filezilla is trying to use X11 even when the Gdk backend is Wayland, thus the crash.

(filezilla:11673): GLib-GObject-WARNING **: invalid cast from 'GdkWaylandDisplay' to 'GdkX11Display'

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff12bdb39 in _XSend () from /lib64/libX11.so.6

#0  0x00007ffff12bdb39 in _XSend () from /lib64/libX11.so.6
#1  0x00007ffff12bdf45 in _XFlush () from /lib64/libX11.so.6
#2  0x00007ffff12c0ac5 in _XGetRequest () from /lib64/libX11.so.6
#3  0x00007ffff130d0fb in _XkbGetGetMapReq.isra.5 () from /lib64/libX11.so.6
#4  0x00007ffff130e94d in XkbGetMapChanges () from /lib64/libX11.so.6
#5  0x00007ffff130aabf in XKeysymToKeycode () from /lib64/libX11.so.6
#6  0x00007ffff683bc64 in wxGetKeyState(wxKeyCode) () from /lib64/libwx_gtk3u_core-3.0.so.0
#7  0x00005555556d892e in wxListCtrlEx::ReadColumnWidths (this=this@entry=0x5555563f2d50, optionId=optionId@entry=75) at listctrlex.cpp:531
#8  0x00005555556d8d78 in wxListCtrlEx::LoadColumnSettings (this=this@entry=0x5555563f2d50, widthsOptionId=widthsOptionId@entry=75, 
    visibilityOptionId=visibilityOptionId@entry=-1, sortOptionId=sortOptionId@entry=-1) at listctrlex.cpp:435
#9  0x0000555555732cbb in CQueueViewBase::CreateColumns (this=this@entry=0x5555563f2d50, extraColumns=...) at queue.cpp:1221
#10 0x000055555574200f in CQueueView::CQueueView (this=0x5555563f2d50, parent=<optimized out>, index=<optimized out>, 
    pMainFrame=<optimized out>, pAsyncRequestQueue=0x5555563d9c60) at QueueView.cpp:457
#11 0x00005555557305f6 in CQueue::CQueue (this=0x5555563e8000, parent=<optimized out>, pMainFrame=0x55555618ea00, 
    pAsyncRequestQueue=0x5555563d9c60) at queue.cpp:1514
#12 0x000055555570c2ee in CMainFrame::CMainFrame (this=0x55555618ea00) at Mainfrm.cpp:341
#13 0x00005555556a6a67 in CFileZillaApp::OnInit (this=0x555555cca200) at FileZilla.cpp:248
#14 0x00007ffff5de2072 in wxEntry(int&, wchar_t**) () from /lib64/libwx_baseu-3.0.so.0
#15 0x0000555555623ce9 in main (argc=1, argv=0x7fffffffdbb8) at locale_initializer.cpp:98

Obviously, forcing the gdk backend to X11 avoids the crash (GDK_BACKEND=x11 filezilla) but it's not a fix.
Comment 16 František Zatloukal 2015-12-22 14:04:13 UTC 
If forcing GDK backend to X11 helps this could be "worked around" by forcing X11 through the .desktop file (or better by adding startup script which will force the X11 backend a then launch real binary).
Comment 17 Heiko Adams 2016-01-14 16:31:14 UTC 
Any progress on this issue?
Comment 18 Matthias Clasen 2016-08-31 22:53:14 UTC 
Looks like an issue in wxGTK3
Comment 19 Scott Talbert 2016-09-02 01:14:55 UTC 
*** Bug 1362258 has been marked as a duplicate of this bug. ***
Comment 20 Scott Talbert 2016-09-02 04:30:27 UTC 
Oddly, I'm not able to reproduce this, at least on F24.  I can see wxGTK calling XKeysymToKeycode.  It doesn't work, but it doesn't crash either.
Comment 21 Christian Stadelmann 2016-09-02 07:04:18 UTC 
Hm, I ran into a pretty similiar bug on F24 just 1 month ago, see #1356289. Right now I can't reproduce either of them.
Comment 22 Olivier Fourdan 2016-09-02 07:23:27 UTC 
These bugs are causes by apps or toolkits wrongly assuming their GdkDisplay is necessarily a GdkX11Display (ie the backend is always X11) whereas with Wayland, well, it's not...

If you cannot reproduce, either the app has been fixed or the launcher was changed to use the X11 backend even on Wayland, I can't think of anything else.
Comment 23 Christian Stadelmann 2016-09-02 07:41:44 UTC 
(In reply to Olivier Fourdan from comment #22)
> If you cannot reproduce, either the app has been fixed or the launcher was
> changed to use the X11 backend even on Wayland, I can't think of anything
> else.

Gtk-Inspector (Ctrl+Shift+I on any Gtk+ 3.x app) shows that filezilla is running with Wayland as Gdk backend.

I don't think this has been fixed though, because neither wxGTK3 nor filezilla have seen any updates since I reported bug #1356289 on 2016-07-13. Maybe this bug is just not easy to reproduce.
Comment 24 Scott Talbert 2016-09-03 00:55:25 UTC 
I submitted a PR to wxWidgets upstream:
https://github.com/wxWidgets/wxWidgets/pull/320

I'll pull it into Fedora if/when they are happy with it.
Comment 25 Scott Talbert 2016-09-03 01:07:14 UTC 
*** Bug 1356289 has been marked as a duplicate of this bug. ***
Comment 26 Scott Talbert 2016-09-14 00:25:31 UTC 
*** Bug 1370227 has been marked as a duplicate of this bug. ***
Comment 27 Fedora Update System 2016-09-15 15:01:04 UTC 
wxGTK-2.8.12-24.fc23 wxGTK3-3.0.2-21.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-835be81af6
Comment 28 Fedora Update System 2016-09-15 15:01:25 UTC 
wxGTK-2.8.12-24.fc24 wxGTK3-3.0.2-21.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2d04da1545
Comment 29 Fedora Update System 2016-09-15 15:01:42 UTC 
wxGTK-2.8.12-24.fc25 wxGTK3-3.0.2-21.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e3e076fdba
Comment 30 Fedora Update System 2016-09-16 00:52:04 UTC 
wxGTK-2.8.12-24.fc23, wxGTK3-3.0.2-21.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-835be81af6
Comment 31 Fedora Update System 2016-09-16 00:53:32 UTC 
wxGTK-2.8.12-24.fc24, wxGTK3-3.0.2-21.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2d04da1545
Comment 32 Fedora Update System 2016-09-16 01:24:04 UTC 
wxGTK-2.8.12-24.fc25, wxGTK3-3.0.2-21.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e3e076fdba
Comment 33 Scott Talbert 2016-09-16 13:53:26 UTC 
*** Bug 1361550 has been marked as a duplicate of this bug. ***
Comment 34 Scott Talbert 2016-09-16 13:55:40 UTC 
*** Bug 1321343 has been marked as a duplicate of this bug. ***
Comment 35 Scott Talbert 2016-09-16 13:56:46 UTC 
*** Bug 1358027 has been marked as a duplicate of this bug. ***
Comment 36 Scott Talbert 2016-09-16 13:58:01 UTC 
*** Bug 1362172 has been marked as a duplicate of this bug. ***
Comment 37 Scott Talbert 2016-09-16 13:58:46 UTC 
*** Bug 1364468 has been marked as a duplicate of this bug. ***
Comment 38 Scott Talbert 2016-09-16 14:00:02 UTC 
*** Bug 1368749 has been marked as a duplicate of this bug. ***
Comment 39 Scott Talbert 2016-09-16 14:00:38 UTC 
*** Bug 1374914 has been marked as a duplicate of this bug. ***
Comment 40 Scott Talbert 2016-09-16 14:09:07 UTC 
If some of the folks who are seeing filezilla crashes under Wayland could test this wxGTK3 update and verify it resolves the crashes, that would be appreciated.
Comment 41 Fedora Update System 2016-09-20 03:49:56 UTC 
wxGTK3-3.0.2-23.fc23 wxGTK-2.8.12-26.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6af21a57ce
Comment 42 Fedora Update System 2016-09-20 03:50:28 UTC 
wxGTK3-3.0.2-23.fc24 wxGTK-2.8.12-26.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3560aaba49
Comment 43 Fedora Update System 2016-09-20 03:50:46 UTC 
wxGTK3-3.0.2-23.fc25 wxGTK-2.8.12-26.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-89935dbd98
Comment 44 Fedora Update System 2016-09-20 19:57:02 UTC 
wxGTK-2.8.12-26.fc25, wxGTK3-3.0.2-23.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-89935dbd98
Comment 45 Fedora Update System 2016-09-22 01:24:51 UTC 
wxGTK-2.8.12-26.fc23, wxGTK3-3.0.2-23.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6af21a57ce
Comment 46 Fedora Update System 2016-09-22 01:25:46 UTC 
wxGTK-2.8.12-26.fc24, wxGTK3-3.0.2-23.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3560aaba49
Comment 47 František Zatloukal 2016-09-23 10:19:19 UTC 
(In reply to Scott Talbert from comment #40)
> If some of the folks who are seeing filezilla crashes under Wayland could
> test this wxGTK3 update and verify it resolves the crashes, that would be
> appreciated.

Fixes the issue, thanks.
Comment 48 Fedora Update System 2016-09-27 00:36:57 UTC 
wxGTK-2.8.12-26.fc25, wxGTK3-3.0.2-23.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 49 Fedora Update System 2016-09-27 03:51:33 UTC 
wxGTK-2.8.12-26.fc24, wxGTK3-3.0.2-23.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 50 Fedora Update System 2016-09-29 22:51:10 UTC 
wxGTK-2.8.12-26.fc23, wxGTK3-3.0.2-23.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.