Bug 1273977
Summary: | Remote-viewer crash after login to VM | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Vaclav Ehrlich <vehrlich> | ||||
Component: | mingw-virt-viewer | Assignee: | Default Assignee for SPICE Bugs <rh-spice-bugs> | ||||
Status: | CLOSED ERRATA | QA Contact: | SPICE QE bug list <spice-qe-bugs> | ||||
Severity: | urgent | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 3.6.0 | CC: | astepano, bgraveno, bsanford, cfergeau, dblechte, djasa, fidencio, gklein, lsurette, rbalakri, Rhev-m-bugs, sherold, tpelka, uril, vehrlich, yeylon, ykaul | ||||
Target Milestone: | ovirt-3.6.1 | ||||||
Target Release: | 3.6.1 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | mingw-libgovirt-0.3.3-2.el7ev mingw-virt-viewer-2.0-6.el7ev rhevm-spice-client-3.6-4 | Doc Type: | Bug Fix | ||||
Doc Text: |
Improved memory handling so that applications using the libgovirt library no longer crash when multiple ISO domains with the same name are found in REST requests. Applications using libgovirt no longer crash due to memory corruption.
|
Story Points: | --- | ||||
Clone Of: | |||||||
: | 1274355 1274356 (view as bug list) | Environment: | |||||
Last Closed: | 2016-03-09 20:12:01 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | Spice | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1274355, 1274356 | ||||||
Attachments: |
|
Description
Vaclav Ehrlich
2015-10-21 16:06:12 UTC
Just forgot mention that this started after update RHEVM from build 15 to 16 Why is not filed under mingw-virt-viewer component? I'm not sure why you are debugging a Windows client with gdb, but in any case, debug symbols would have helped get a better stack, I reckon. I'm sure there's a debug build available somewhere. (In reply to Yaniv Kaul from comment #2) > Why is not filed under mingw-virt-viewer component? Well because if you remove ovirt part from *vv file, mingw-virt-viewer works without segfault. But I guess you mean that portal do everything right so I'll change the component. Created attachment 1085475 [details]
--debug --spice-debug run
Seems to be a mingw-libgovirt problem. #0 g_type_check_instance_is_fundamentally_a ( type_instance=type_instance@entry=0x519b9e0, fundamental_type=fundamental_type@entry=80) at ../../gobject/gtype.c:3981 #1 0x63c4a47b in g_object_unref (_object=0x519b9e0) at ../../gobject/gobject.c:3067 #2 0x64842fb0 in ovirt_collection_refresh_from_xml (collection=0x50d4450, root_node=<optimized out>, error=0x28fb8c) at ../../govirt/ovirt-collection.c:276 #3 0x64843c49 in get_collection_xml_async_cb (proxy=0x3aebfd0, call=0x50d28a0, user_data=0x29c2ce0, error=0x28fb8c) at ../../govirt/ovirt-proxy.c:343 #4 0x64843bb2 in call_async_cb (call=0x50d28a0, error=0x0, weak_object=0x0, user_data=0x50d8680) at ../../govirt/ovirt-proxy.c:248 #5 0x00023fa7 in ?? () from C:\Program Files (x86)\VirtViewer v2.0-80\bin\librest-0.7-0.dll #6 0x051600e0 in ?? () Just for the record, this is the libgovirt commit that solves the issue: 7b48a957f733704f7dddd3b682111675e989666c (In reply to Vaclav Ehrlich from comment #4) > (In reply to Yaniv Kaul from comment #2) > > Why is not filed under mingw-virt-viewer component? > > Well because if you remove ovirt part from *vv file, mingw-virt-viewer works > without segfault. But I guess you mean that portal do everything right so > I'll change the component. For sure builds 15 and 16 behave differently, and we need to find first of all why, and what version behaves correctly prior to change the component. This should be a blocker issue. The client should not crash, it is the second issue, not a blocker. As indicated in https://bugzilla.redhat.com/show_bug.cgi?id=1274356#c6 : « This bug is happening because the are 2 storage domains in the RHEV setup, and they both have the same name ('iso'). This triggers an untested code path in libgovirt, where some memory corruption happens. This could not happen with rhev 3.5 or older as the foreign menu code was not used (if I'm not mistaken). I have no idea how likely it is that customers will have storage domains with the same names (but the same crash woulod occur with VMs with the same names too). However, given that the fix is small, better be safe than sorry and make a zstream update for that. While we should make sure the zstream is released around the same time as 3.6 GA, I'm not sure this should be marked as a blocker as it only happens on some setups. » Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2016-0377.html |