Bug 127526
| Summary: | glibc-kernheaders breaks dosfstools build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Grubb <linux_4ever> | ||||
| Component: | dosfstools | Assignee: | Peter Vrabec <pvrabec> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Ben Levenson <benl> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 14 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-02-21 19:04:22 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
fixed for the next build Re-open, not fixed in current tree dosfstools is broken itself it uses __u8 *in it's own C code* without including <asm/types.h> the original complaint of this bug was that some header used __u8 without that header also including the definition of those types; that got fixed. However the app itself forgetting to include them we can't fix obviously. Created attachment 103509 [details]
new patch for dosfstools
The current status of this problem report is that the patch to
glibc-kernheaders I submitted is no longer needed. However, dosfstools still
does not compile without patching. I will attach a patch that I apply to
dosfstools in case fixing dosfstools is the approach taken; or it has some
insight into the issue.
Problem solved by Jeremy Katz patch in dosfstools-2.8-14. Resolved as duplicate of #134834 *** This bug has been marked as a duplicate of 134834 *** Changed to 'CLOSED' state since 'RESOLVED' has been deprecated. |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4.2) Gecko/20040308 Description of problem: The latest version of glibc-kernheaders breaks the build of dosfstools: /usr/include/linux/msdos_fs.h:115: error: parse error before "__s8" /usr/include/linux/msdos_fs.h:118: error: parse error before "sector_size" /usr/include/linux/msdos_fs.h:119: error: parse error before "cluster_size" The problem is that linux/types.h is not being included. This defines __s8 & __u8 among other things. I created this patch: diff -ur glibc-kernheaders-2.4.orig/usr/include/linux/msdos_fs.h glibc-kernheaders-2.4/usr/include/linux/msdos_fs.h --- glibc-kernheaders-2.4.orig/usr/include/linux/msdos_fs.h 2003-08-03 07:44:11.000000000 -0400 +++ glibc-kernheaders-2.4/usr/include/linux/msdos_fs.h 2004-07-08 08:02:15.000000000 -0400 @@ -7,6 +7,7 @@ #include <linux/fs.h> #include <linux/stat.h> #include <linux/fd.h> +#include <linux/types.h> #define MSDOS_ROOT_INO 1 /* == MINIX_ROOT_INO */ #define SECTOR_SIZE 512 /* sector size (bytes) */ And I also had to patch mkdosfs.c to include linux/types.h. I don't think this is normal and I'll probably need more patching in various packages. Version-Release number of selected component (if applicable): glibc-kernheaders-2.4-9.1.84 How reproducible: Always Steps to Reproduce: 1. rpm -ivh glibc-kernheaders-2.4-9.1.84.i386.rpm 2. rpm -ivh dosfstools-2.8-12.src.rpm 3. rpmbuild -bb /usr/src/redhat/SPECS/dosfstools.spec Additional info: Dosfstools cannot compile with glibc-kernheaders in its current state. glibc-kernheaders-2.4-9.src.rpm was fine and did not exhibit this problem.