Bug 1277484 (nette/nette)

Summary: Review Request: php-nette - Nette Framework
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-02 21:22:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1277375, 1277376, 1277377, 1277379, 1277384, 1277388, 1277395, 1277397, 1277400, 1277407, 1277409, 1277413, 1277415, 1277418, 1277434, 1277437, 1277441, 1277465, 1277470, 1277474, 1277476, 1277478    
Bug Blocks: 1277493    
Attachments:
Description Flags
phpcompatinfo-full.php
none
phpcompatinfo-lib.php
none
fedora-review.txt none

Description Remi Collet 2015-11-03 12:51:47 UTC 
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/f1124e906d8759cb3536917e32fdc2185faac5cb/php/nette/php-nette/php-nette.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-nette-2.3.7-1.remi.src.rpm
Description: 
Nette Framework is a popular tool for PHP web development
It is designed to be as usable and as friendly as possible.
It focuses on security and performance and is definitely one
of the safest PHP frameworks.

Nette Framework speaks your language and helps you to easily build better websites.
Cache accelerates your application by storing data, once hardly retrieved,
for future use.

To use this library, you just have to add, in your project:
  require_once '/usr/share/php/Nette/autoload.php';

Fedora Account System Username: remi
Comment 1 Remi Collet 2015-12-03 14:48:34 UTC 
Update to 2.3.8: https://github.com/remicollet/remirepo/commit/e7e1d7a2ddde4d1f1d455a73bfe153c8679c5689

Spec: https://raw.githubusercontent.com/remicollet/remirepo/e7e1d7a2ddde4d1f1d455a73bfe153c8679c5689/php/nette/php-nette/php-nette.spec

Srpm: http://rpms.famillecollet.com/SRPMS/php-nette-2.3.8-1.remi.src.rpm
Comment 2 Remi Collet 2015-12-04 07:21:48 UTC 
All the reviews and already approved packages are updated to match minimal version required by this meta package.
Comment 3 Upstream Release Monitoring 2015-12-06 18:50:33 UTC 
pbrobinson's scratch build of php-nette-php-generator?#27aa0e4b766e380ae39ab910d4d0d7255a7172fc for epel7-archbootstrap and git://pkgs.fedoraproject.org/php-nette-php-generator?#27aa0e4b766e380ae39ab910d4d0d7255a7172fc completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12090326
Comment 4 Shawn Iwinski 2016-02-22 12:56:14 UTC 
Created attachment 1129305 [details]
phpcompatinfo-full.php

phpCompatInfo version 5.0.0 DB built Jan 09 2016 15:36:21 CET
Comment 5 Shawn Iwinski 2016-02-22 12:56:37 UTC 
Created attachment 1129306 [details]
phpcompatinfo-lib.php

phpCompatInfo version 5.0.0 DB built Jan 09 2016 15:36:21 CET
Comment 6 Shawn Iwinski 2016-02-22 12:57:07 UTC 
Created attachment 1129307 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1277484
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comment 7 Shawn Iwinski 2016-02-22 12:57:30 UTC 
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/php/Nette(php-
     nette-utils, php-nette-tokenizer, php-nette-safe-stream, php-nette-
     neon)
Comment 8 Remi Collet 2016-02-22 13:17:51 UTC 
Damn... good catch

Fix: https://github.com/remicollet/remirepo/commit/a1b9e61c5fed42ed259215a51f18b1fc1b024494

Spec: https://raw.githubusercontent.com/remicollet/remirepo/a1b9e61c5fed42ed259215a51f18b1fc1b024494/php/nette/php-nette/php-nette.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-nette-2.3.8-2.remi.src.rpm
Comment 9 Shawn Iwinski 2016-02-22 14:13:29 UTC 
[x]: Package does not own files or directories owned by other packages.



[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



No blockers.

===== APPROVED =====
Comment 10 Gwyn Ciesla 2016-02-22 14:43:08 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-nette
Comment 11 Fedora Update System 2016-02-22 15:42:46 UTC 
php-nette-2.3.9-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab6c547355
Comment 12 Fedora Update System 2016-02-22 15:42:47 UTC 
php-nette-2.3.9-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a21d82c75
Comment 13 Fedora Update System 2016-02-22 15:42:48 UTC 
php-nette-2.3.9-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a21d82c75
Comment 14 Fedora Update System 2016-02-22 15:42:50 UTC 
php-nette-2.3.9-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a21d82c75
Comment 15 Fedora Update System 2016-02-22 15:42:52 UTC 
php-nette-2.3.9-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d9c8a9ad7f
Comment 16 Fedora Update System 2016-02-22 15:42:54 UTC 
php-nette-2.3.9-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-22d9369b13
Comment 17 Fedora Update System 2016-02-22 21:20:17 UTC 
php-nette-2.3.9-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-22d9369b13
Comment 18 Fedora Update System 2016-02-23 02:20:53 UTC 
php-nette-2.3.9-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d9c8a9ad7f
Comment 19 Fedora Update System 2016-02-23 02:52:11 UTC 
php-nette-2.3.9-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a21d82c75
Comment 20 Fedora Update System 2016-02-23 15:20:00 UTC 
php-nette-2.3.9-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab6c547355
Comment 21 Fedora Update System 2016-03-02 21:22:56 UTC 
php-nette-2.3.9-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
Comment 22 Fedora Update System 2016-03-02 21:51:16 UTC 
php-nette-2.3.9-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
Comment 23 Fedora Update System 2016-03-09 14:27:23 UTC 
php-nette-2.3.9-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
Comment 24 Fedora Update System 2016-03-09 14:59:41 UTC 
php-nette-2.3.9-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.