Bug 1277415 (nette/http) - Review Request: php-nette-http - Nette HTTP Component
Summary: Review Request: php-nette-http - Nette HTTP Component
Keywords:
Status: CLOSED ERRATA
Alias: nette/http
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: nette/tester nette/utils nette/finder nette/di
Blocks: nette/security nette/forms 1277470 nette/bootstrap nette/nette
TreeView+ depends on / blocked
 
Reported: 2015-11-03 09:42 UTC by Remi Collet
Modified: 2015-12-29 03:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-01 09:30:53 UTC
Type: ---
Embargoed:
shawn: fedora-review+


Attachments (Terms of Use)
phpcompatinfo-full.log (15.77 KB, text/plain)
2015-11-29 01:21 UTC, Shawn Iwinski
no flags Details
phpcompatinfo-lib.log (15.14 KB, text/plain)
2015-11-29 01:21 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (7.42 KB, text/plain)
2015-11-29 01:22 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2015-11-03 09:42:03 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/master/php/nette/php-nette-http/php-nette-http.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-nette-http-2.3.3-1.remi.src.rpm
Description: 
HTTP request and response are encapsulated in Nette\Http\Request and
Nette\Http\Response objects which offer comfortable API and also act
as sanitization filter.

To use this library, you just have to add, in your project:
  require_once '/usr/share/php/Nette/Http/autoload.php';

Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2015-11-29 01:21:19 UTC
Created attachment 1100054 [details]
phpcompatinfo-full.log

phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:52:03 CEST

Comment 2 Shawn Iwinski 2015-11-29 01:21:41 UTC
Created attachment 1100055 [details]
phpcompatinfo-lib.log

phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:52:03 CEST

Comment 3 Shawn Iwinski 2015-11-29 01:22:10 UTC
Created attachment 1100056 [details]
fedora-review.txt

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1277415
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Shawn Iwinski 2015-11-29 01:25:43 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import.



[x]: Requires correct, justified where necessary.

     From composer.json:
         "nette/utils": "~2.2, >=2.2.2"
     For spec:
         #        "nette/utils": "~2.2"
         Requires:       php-composer(%{gh_owner}/utils) >= 2.2



[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).

Diff spec file in url and in SRPM
---------------------------------
--- 1277415-php-nette-http/srpm/php-nette-http.spec	2015-11-28 10:25:06.305750424 -0500
+++ 1277415-php-nette-http/srpm-unpacked/php-nette-http.spec	2015-10-30 09:11:33.000000000 -0400
@@ -102,6 +102,6 @@
 %check
 %if %{with_tests}
-%if 0%{?rhel} == 7
 : Ignore failed test - only bad message
+%if 0%{?rhel} == 7
 rm tests/Http/Session.start.error.phpt
 %endif



No blockers.

===== APPROVED =====

Comment 5 Remi Collet 2015-11-29 07:46:26 UTC
Thanks.

SCM request open on pkgdb

Comment 6 Till Maas 2015-11-29 15:23:34 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/php-nette-http

Comment 7 Fedora Update System 2015-11-29 16:51:56 UTC
php-nette-http-2.3.3-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-23dff104b1

Comment 8 Fedora Update System 2015-11-29 16:52:01 UTC
php-nette-http-2.3.3-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-b9c7cfc4ca

Comment 9 Fedora Update System 2015-11-29 16:52:01 UTC
php-nette-http-2.3.3-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-d8ce6d8ac8

Comment 10 Fedora Update System 2015-11-29 21:50:23 UTC
php-nette-http-2.3.3-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update php-nette-http'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-b9c7cfc4ca

Comment 11 Fedora Update System 2015-11-29 22:20:20 UTC
php-nette-http-2.3.3-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-nette-http'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-23dff104b1

Comment 12 Fedora Update System 2015-11-29 23:52:21 UTC
php-nette-http-2.3.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-nette-http'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-29c3aede0b

Comment 13 Fedora Update System 2015-11-30 05:20:40 UTC
php-nette-http-2.3.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update php-nette-http'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-d8ce6d8ac8

Comment 14 Fedora Update System 2015-12-15 13:24:55 UTC
php-nette-http-2.3.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2015-12-15 15:21:33 UTC
php-nette-http-2.3.3-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2015-12-28 21:27:07 UTC
php-nette-http-2.3.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-12-29 03:54:10 UTC
php-nette-http-2.3.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.